feat: allow folder drag-drop to speed workspace setup#173
feat: allow folder drag-drop to speed workspace setup#173Dimillian merged 3 commits intoDimillian:mainfrom
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 78137981b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const selection = path.trim(); | ||
| if (!selection) { | ||
| return null; |
There was a problem hiding this comment.
In addWorkspaceFromPath, the incoming path is normalized with trim(). On macOS/Linux, directory names can legally start or end with whitespace, so trimming changes the actual filesystem path and can make a valid folder (e.g., a workspace named with leading/trailing spaces) fail to add. This is a regression because addWorkspace now delegates to this helper, so even file‑picker selections get trimmed. Consider removing the trim or limiting it to known drag/drop artifacts instead of always mutating the path.
Useful? React with 👍 / 👎.
This reverts commit c2f12de.
|
FYI I had to revert it, please rework it and test it properly. It broke the drag image in the composer to attach. |
|
@Dimillian Sorry for that regression. Fixed in #184 |
2 participants
Summary
Addresses #156
useWorkspaceDropZoneto handle drag state, dedupe drops, and extract paths from both web and Tauri drag events.addWorkspaceFromPathand server-side path validation (is_workspace_path_dir) to accept only directories and reuse the existing add flow.Evidence
Screen.Recording.2026-01-20.at.23.58.26.mov
Testing