Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions src/utils/threadItems.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -173,4 +173,43 @@ describe("threadItems", () => {
text: "Hello",
});
});

it("keeps later optimistic duplicates when the matching remote item is already local", () => {
const remote: ConversationItem[] = [
{
id: "remote-1",
kind: "message",
role: "user",
text: "Hello",
},
];
const local: ConversationItem[] = [
{
id: "remote-1",
kind: "message",
role: "user",
text: "Hello",
},
{
id: "9999-user",
kind: "message",
role: "user",
text: "Hello",
},
];
const merged = mergeThreadItems(remote, local);
expect(merged).toHaveLength(2);
expect(merged[0]).toMatchObject({
id: "remote-1",
kind: "message",
role: "user",
text: "Hello",
});
expect(merged[1]).toMatchObject({
id: "9999-user",
kind: "message",
role: "user",
text: "Hello",
});
});
});
4 changes: 4 additions & 0 deletions src/utils/threadItems.ts
Original file line number Diff line number Diff line change
Expand Up @@ -445,8 +445,12 @@ export function mergeThreadItems(
return remoteItems;
}
const byId = new Map(remoteItems.map((item) => [item.id, item]));
const localIds = new Set(localItems.map((item) => item.id));
const remoteMessageCounts = new Map<string, number>();
remoteItems.forEach((item) => {
if (localIds.has(item.id)) {
return;
}
const key = messageDedupKey(item);
if (!key) {
return;
Expand Down