Skip to content

make profile name selectable #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tlaster merged 1 commit into from
Feb 13, 2026
Merged

make profile name selectable #1799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions compose-ui/src/commonMain/kotlin/dev/dimension/flare/ui/component/CommonProfileHeader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.statusBars
import androidx.compose.foundation.text.selection.SelectionContainer
import androidx.compose.runtime.Composable
import androidx.compose.runtime.remember
import androidx.compose.ui.Alignment
Expand Down Expand Up @@ -172,32 +173,34 @@ internal fun CommonProfileHeader(
}.padding(horizontal = screenHorizontalPadding, vertical = 8.dp),
verticalArrangement = Arrangement.spacedBy(8.dp),
) {
Column {
RichText(
text = displayName,
textStyle = PlatformTheme.typography.title,
SelectionContainer {
Column {
RichText(
text = displayName,
textStyle = PlatformTheme.typography.title,
// modifier =
// Modifier
// .sharedElement(
// rememberSharedContentState(key = "profile-display-name-$userKey"),
// animatedVisibilityScope = this@AnimatedVisibilityScope,
// ),
)
Row(
horizontalArrangement = Arrangement.spacedBy(4.dp),
verticalAlignment = Alignment.CenterVertically,
) {
PlatformText(
text = handle,
style = PlatformTheme.typography.caption,
)
Row(
horizontalArrangement = Arrangement.spacedBy(4.dp),
verticalAlignment = Alignment.CenterVertically,
) {
PlatformText(
text = handle,
style = PlatformTheme.typography.caption,
// modifier =
// Modifier
// .sharedElement(
// rememberSharedContentState(key = "profile-handle-$userKey"),
// animatedVisibilityScope = this@AnimatedVisibilityScope,
// ),
)
handleTrailing.invoke(this)
)
handleTrailing.invoke(this)
}
}
}
content()
Expand Down
2 changes: 2 additions & 0 deletions iosApp/flare/UI/Component/CommonProfileHeader.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,12 @@ struct CommonProfileHeader: View {
RichText(text: user.name)
.font(.headline)
.frame(maxWidth: .infinity, alignment: .leading)
.textSelection(.enabled)
HStack {
Text(user.handle)
.font(.subheadline)
.foregroundColor(.gray)
.textSelection(.enabled)
ForEach(0..<user.mark.count, id: \.self) { index in
let mark = user.mark[index]
switch mark {
Expand Down
Loading