Merged
Conversation
Suppresses unused error variable warnings in universe handler and trading engine by assigning errors to blank identifiers. Adds explicit error handling for invalid trade types in ExecuteTrade to improve robustness.
Handle unused error variables and invalid trade types
Added a debug log message when an agent decides to HOLD, clarifying that no trade is executed for such decisions.
Log HOLD actions in agent decision processing
Adds error logging for failed sentiment analysis in the MarketContext method to improve observability and debugging.
Log sentiment analysis errors in MarketContext
Update risk_manager.go
Update risk_manager.go
Updated TestAggregateSentiment to explicitly handle the error returned by MarketContext, ensuring no empty branches and clarifying expected error handling when service clients are nil.
Handle error explicitly in service test
1batu
added a commit
that referenced
this pull request
Nov 9, 2025
Add type checks for agent message handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to error handling, logging, and validation logic throughout the trading platform's backend services. The changes focus on making error handling more explicit, improving logging for debugging and monitoring, and clarifying validation logic for trade actions, especially around SELL operations.
Error Handling and Logging Improvements:
MarketContextmethod, ensuring issues are visible in logs.Trade Validation and Execution: