Remove unnessary SSH in release script #1529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1529 +/- ##
=======================================
Coverage 92.28% 92.28%
=======================================
Files 142 142
Lines 8092 8092
=======================================
Hits 7468 7468
Misses 624 624
🚀 New features to boost your workflow:
|
DominicOram
requested changes
Dec 19, 2025
Contributor
DominicOram
left a comment
DominicOram
left a comment
There was a problem hiding this comment.
Great, thanks, just the one comment
| ) | ||
|
|
||
| # SSH into control machine if not in dev mode | ||
| if options.use_control_machine and release_area != DEV_DEPLOY_LOCATION: |
Contributor
There was a problem hiding this comment.
Should: i think we can remove the use_control_machine too
DominicOram
approved these changes
Dec 19, 2025
Contributor
DominicOram
left a comment
DominicOram
left a comment
There was a problem hiding this comment.
Great, thanks. Just the one minor comment
| dev_mode: bool = False | ||
| prune_deployments: bool = True | ||
|
|
||
| # NOTE For i24 for now will need to set it to false from the command line |
Contributor
There was a problem hiding this comment.
Nit: Sorry, this comment should also be deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1505
Instructions to reviewer on how to test:
Checks for reviewer