Read detector ID from device #1526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1526 +/- ##
==========================================
- Coverage 92.29% 92.28% -0.01%
==========================================
Files 142 142
Lines 8094 8092 -2
==========================================
- Hits 7470 7468 -2
Misses 624 624
🚀 New features to boost your workflow:
|
DominicOram
approved these changes
Dec 17, 2025
Contributor
DominicOram
left a comment
DominicOram
left a comment
There was a problem hiding this comment.
Thanks, one minor comment, otherwise looks good
| data_collection_info.sample_id = params.sample_id | ||
| data_collection_info.visit_string = params.visit | ||
| data_collection_info.parent_id = data_collection_group_id | ||
| data_collection_info.detector_id = I03_EIGER_DETECTOR |
Contributor
There was a problem hiding this comment.
Should: We can remove I03_EIGER_DETECTOR now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1472
Link to dodal PR (if required): DiamondLightSource/dodal#1786
Instructions to reviewer on how to test:
Checks for reviewer