-
Notifications
You must be signed in to change notification settings - Fork 0
Implement plans to control the piezos on the focusing mirrors #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
+ Coverage 96.91% 97.07% +0.15%
==========================================
Files 21 22 +1
Lines 421 444 +23
==========================================
+ Hits 408 431 +23
Misses 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DominicOram
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if we can make it so that there doesn't have to be specific plans for this and they could just call run_plan("mv", "vfm-piezo", 100). Especially if they want to be able to scan it at some point too. I'm not sure how we would get this to work with the check_access though, it would need thought
|
They're not going to want to scan this anytime soon (or ever as things stand, but leaving some leeway for changing their minds) so at least there's some time to think about that. I've tried the only one plan solution but I couldn't think of any clean way - happy for any suggestion! |
Closes #110
Needs Dodal#1775