Skip to content

Conversation

@noemifrisina
Copy link
Collaborator

Closes #110

Needs Dodal#1775

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.07%. Comparing base (cecb42c) to head (cf4d6a7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   96.91%   97.07%   +0.15%     
==========================================
  Files          21       22       +1     
  Lines         421      444      +23     
==========================================
+ Hits          408      431      +23     
  Misses         13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@noemifrisina noemifrisina marked this pull request as ready for review December 12, 2025 14:57
Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we can make it so that there doesn't have to be specific plans for this and they could just call run_plan("mv", "vfm-piezo", 100). Especially if they want to be able to scan it at some point too. I'm not sure how we would get this to work with the check_access though, it would need thought

@noemifrisina
Copy link
Collaborator Author

They're not going to want to scan this anytime soon (or ever as things stand, but leaving some leeway for changing their minds) so at least there's some time to think about that.

I've tried the only one plan solution but I couldn't think of any clean way - happy for any suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set the voltage on piezo actuators in focusing mirrors

3 participants