Skip to content

Conversation

@dkazanc
Copy link
Collaborator

@dkazanc dkazanc commented Jan 19, 2026

This moves block.to_cpu() from writing doing the transfer in dataset_store, which doesn't seem the right place. I've added some logic around how to recognise that the block needs to be moved. Also to be able to clock with the monitor the device to host transfer time.
The resulting csv file reflects the intended behavior. Few tests to fix.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation

@dkazanc dkazanc marked this pull request as ready for review January 20, 2026 10:25
@dkazanc
Copy link
Collaborator Author

dkazanc commented Jan 20, 2026

@yousefmoazzam I think it is ready but I couldn't get my head around one last failing test: test_execute_section_for_block. Can you have a look please? cheers

@dkazanc dkazanc requested a review from yousefmoazzam January 20, 2026 10:27
@dkazanc dkazanc merged commit 3540be4 into main Jan 23, 2026
4 of 5 checks passed
@dkazanc dkazanc deleted the block_to_cpu_move branch January 23, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants