-
Notifications
You must be signed in to change notification settings - Fork 3
feat: migrate to Cosmo Router #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3462a9d to
be6ed0c
Compare
GDYendell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without knowing the details of the specific wundergraph config it is hard to comment much, but this all seems pretty reasonable to me.
| prometheus.io/port: "8088" | ||
| prometheus.io/path: "/metrics" | ||
|
|
||
| commonConfiguration: |- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this config in the stable template, nightly template, and the values? Don't we only need a stable and a nightly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, probably doesn't all need repeating.
be6ed0c to
06cfa36
Compare
Migrates from Apollo router to Cosmo router.
Tested on Pollux in graph namespace.
Have not tested otel, jaeger.
N.B. supergraph-config.yaml format has changed, so Create Schema Comparison Comment action fails.