add hybrid fastcs/adodin eiger. moved from ophyd_async branch #1745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RJCD-Diamond
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1745 +/- ##
==========================================
+ Coverage 99.10% 99.11% +0.01%
==========================================
Files 279 281 +2
Lines 10510 10650 +140
==========================================
+ Hits 10416 10556 +140
Misses 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DominicOram
requested changes
Dec 9, 2025
Contributor
DominicOram
left a comment
DominicOram
left a comment
There was a problem hiding this comment.
Thanks, I think this is mostly fine my only comments would be:
- Should: We should remove the one in
ophyd_asyncnow. I think that this is the only place it's used in DLS and I don't think it's yet used anywhere else. Otherwise having the two is confusing - Nit: I don't think the
adin the path or filename adds anything as we don't have one that's not AD yet and once we do we should prioritise moving to that so hopefully this isn't around for long. e.g. I would just call itsrc/dodal/devices/async_eiger/odin_io.py
Comment on lines
+23
to
+24
| "python-envs.defaultEnvManager": "ms-python.python:system", | ||
| "python-envs.pythonProjects": [] |
Contributor
There was a problem hiding this comment.
Nit: Why were these added?
Contributor
|
Also, FYI @jacob720, can you take a look at this as you've been working on it too? |
This was referenced Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussions with @coretl and given the fact that we will be removing the adodin in order to only support fascs odin, the adodin module has been moved to dls-dodal in order to maintain compatibility until all EIger's have been moved to fascs odin
bluesky/ophyd-async#1128