-
Notifications
You must be signed in to change notification settings - Fork 12
Make undulator gap flyable #1470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1470 +/- ##
=======================================
Coverage 99.12% 99.12%
=======================================
Files 283 286 +3
Lines 10736 10781 +45
=======================================
+ Hits 10642 10687 +45
Misses 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic looks good but as far as I can see this is doing the same thing as the standard ophyd-async motor.
I still think we should create a new SafeMotor in dodal/ophyd-async which is a subclass of the standard motor, and gives the behaviour that you need. It would simplify this device quite a bit now
…urce/dodal into make_undulatorGap_flyable
Why wait, it is done but this https://github.com/bluesky/ophyd-async/pull/1152/files is breaking test. |
oliwenmandiamond
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better, but you will also have to mirror this for the tests and split that into its own parts
…urce/dodal into make_undulatorGap_flyable
…urce/dodal into make_undulatorGap_flyable
Fixes #1469 #1261
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}