Add load metadata plan for fastcs eiger#1187
Conversation
DominicOram
left a comment
DominicOram
left a comment
There was a problem hiding this comment.
Thanks! Some suggestions in code, I also think it would be good to just add a __main__ at the bottom of src/dodal/plans/load_eiger_metadata_plan.py that does the full configure, arm, manually trigger and disarm. Just so that we can easily get back to testing
| yield from set_cam_pvs(eiger, detector_params, wait=True) | ||
| LOGGER.info(f"Setting CAM PVs: {time.time() - start}s") | ||
| yield from set_odin_pvs(eiger, detector_params, wait=True) | ||
| LOGGER.info(f"Setting Odin PVs: {time.time() - start}s") | ||
| yield from change_roi_mode(eiger, enable, detector_params, wait=True) | ||
| LOGGER.info(f"Changing ROI Mode: {time.time() - start}s") | ||
| yield from bps.abs_set(eiger.odin.num_frames_chunks, 1) | ||
| LOGGER.info(f"Setting # of Frame Chunks: {time.time() - start}s") | ||
| yield from set_mx_settings_pvs(eiger, detector_params, wait=True) |
There was a problem hiding this comment.
For next time we're testing we should try removing these individual waits, I think the arm should all still work
|
Also, I think this is a duplicate of #1054, can we remove one of them? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1187 +/- ##
==========================================
- Coverage 97.99% 97.96% -0.04%
==========================================
Files 197 198 +1
Lines 7530 7605 +75
==========================================
+ Hits 7379 7450 +71
- Misses 151 155 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DominicOram
left a comment
DominicOram
left a comment
There was a problem hiding this comment.
Great, minor comment. As discussed can you:
- Make a new
ophyd-asyncpre-release - Make sure
mainofdodalworks against that - Pin to the pre-release in this PR
src/dodal/beamlines/i03.py
Outdated
| ) | ||
|
|
||
|
|
||
| @device_factory(skip=BL == "s03") |
There was a problem hiding this comment.
Nit: We don't run with s03 any more so can remove this
DominicOram
left a comment
DominicOram
left a comment
There was a problem hiding this comment.
Should be all good now, thanks!
…tSource/dodal into use_adodin_with_fastcs_eiger
DominicOram
changed the title
2 participants
This PR adds a plan that broadly mimics the the Eiger arming sequence. This was used to test Fastcs-Eiger with ADOdin on i03 with @DominicOram.
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}