-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Remove 404 at "/" #1330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Remove 404 at "/" #1330
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1330 +/- ##
=======================================
Coverage 94.76% 94.76%
=======================================
Files 42 42
Lines 2752 2752
=======================================
Hits 2608 2608
Misses 144 144 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Would it be more appropriate to have the docs url be at My concerns are that:
|
|
I think having
|
|
Okay let's go for it. Should we also have a redirect from the now empty |
I think that is overkill We should also get some opinions from @DiamondLightSource/developers-daq-core |
|
Having Personally I think making Alternatively it could be a landing page with readme level docs/status on - stuff like current version and where to find other services (tiled/glazed/numtracker) as well as a link to the current jsonapi docs and the general docs. Not completely against moving the api docs to |
When interacting with BlueAPI via web browser, the landing page (
/) returns a 404.This has led to other developers having to ask how to access the web-based interface (at
/docs).This PR will have the root page return something meaningful.