Feat/adding lex api #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the zone parameter from 'dsd' to 'lex' in search examples.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the new "lex" API zone as a replacement/alternative to the "dsd" zone, updating the library to use lex.dk instead of denstoredanske.lex.dk.
- Updates API endpoint mapping to include the new 'lex' zone pointing to lex.dk
- Updates all test cases to use 'lex' instead of 'dsd' for consistency
- Updates documentation examples to demonstrate the new 'lex' zone usage
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| snldata/client.py | Adds 'lex' zone mapping to lex.dk API and SHORT_TO_LONG dictionary |
| tests/test_client.py | Updates all test method names and zone parameters from 'dsd' to 'lex' |
| setup.py | Bumps version from 1.1.3 to 1.1.4 |
| README.md | Updates documentation table and examples to use 'lex' zone instead of 'dsd' |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.