Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis pull request updates the CI workflow configuration to declare environment variables in explicit 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/cli/test/ci-contract.test.js (1)
14-14: Scope thepackage-smokeblock extraction more tightly.Line [14] currently captures from
package-smoketo end-of-file, which can mask regressions if more jobs are added later and happen to match the assertions.🔧 Suggested hardening diff
- const packageSmoke = text.match(/ package-smoke:[\s\S]*/)?.[0] ?? ""; + const packageSmoke = text.match( + /^ package-smoke:[\s\S]*?(?=^ [a-z0-9_-]+:|(?![\s\S]))/m + )?.[0] ?? "";🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/cli/test/ci-contract.test.js` at line 14, The current extraction stored in the packageSmoke variable uses a greedy regex (text.match(/ package-smoke:[\s\S]*/)) which captures to EOF; change the match call that defines packageSmoke to use a non-greedy pattern with a lookahead so it stops at the next top-level job or end-of-file (e.g. replace the regex with a non-greedy variant and a lookahead such as using [\s\S]*? with (?=\n {2}\S|$)); update the text.match invocation that assigns packageSmoke to use this tightened regex so only the package-smoke job block is captured.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/cli/test/ci-contract.test.js`:
- Line 14: The current extraction stored in the packageSmoke variable uses a
greedy regex (text.match(/ package-smoke:[\s\S]*/)) which captures to EOF;
change the match call that defines packageSmoke to use a non-greedy pattern with
a lookahead so it stops at the next top-level job or end-of-file (e.g. replace
the regex with a non-greedy variant and a lookahead such as using [\s\S]*? with
(?=\n {2}\S|$)); update the text.match invocation that assigns packageSmoke to
use this tightened regex so only the package-smoke job block is captured.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b72ca797-44bf-4e88-8e7f-95b74f9d4202
📒 Files selected for processing (6)
.github/workflows/ci.ymlpackages/cli/scripts/test.jspackages/cli/test/ci-contract.test.jspackages/cli/test/codexchat-lib.test.jspackages/cli/test/install-lib.test.jspackages/cli/test/release-contract.test.js
1 participant
Summary\n- fix Windows package-smoke env syntax in CI\n- add a workflow contract test so it does not regress\n- include that test in the CLI package test runner\n\n## Testing\n- node --test packages/cli/test/ci-contract.test.js\n- bun run test\n- bun run check