Skip to content

🎨 Palette: Add ARIA labels and hide visual text for icon-only buttons in ConversationsSidebar#276

Draft
Dexploarer wants to merge 1 commit intomainfrom
palette/fix-aria-labels-conversations-sidebar-12696044689972972279
Draft

🎨 Palette: Add ARIA labels and hide visual text for icon-only buttons in ConversationsSidebar#276
Dexploarer wants to merge 1 commit intomainfrom
palette/fix-aria-labels-conversations-sidebar-12696044689972972279

Conversation

@Dexploarer
Copy link
Owner

💡 What

Added missing aria-label to the "Delete conversation" icon-only button and wrapped the visual text icons (× and &times;) inside <span aria-hidden="true"> in the ConversationsSidebar component.

🎯 Why

Screen readers will reliably read the aria-label attribute on the button, and hiding the visual text ensures that it isn't awkwardly announced as "times" or "multiplication sign" along with the intended action text.

📸 Before/After

Before:

<button ... title="Delete conversation">×</button>
<button ... aria-label="Close chats panel">&times;</button>

After:

<button ... title="Delete conversation" aria-label="Delete conversation"><span aria-hidden="true">×</span></button>
<button ... aria-label="Close chats panel"><span aria-hidden="true">&times;</span></button>

♿ Accessibility

This improves screen reader compatibility when interacting with the Conversation sidebar, preventing confusing announcements for icon-only buttons.


PR created automatically by Jules for task 12696044689972972279 started by @Dexploarer

@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions bot added the ui label Mar 19, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the accessibility of the ConversationsSidebar component for users relying on screen readers. By introducing explicit aria-label attributes and strategically hiding purely visual text from assistive technologies, the changes ensure that interactive elements are correctly identified and their intended actions are clearly communicated, leading to a more inclusive user experience.

Highlights

  • Accessibility: Added missing aria-label to the 'Delete conversation' icon-only button to provide clear context for screen readers.
  • Accessibility: Wrapped visual text icons (× and &times;) within <span aria-hidden="true"> tags for both 'Close chats panel' and 'Delete conversation' buttons, preventing awkward announcements by screen readers.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@@ -119,7 +119,7 @@ export function ConversationsSidebar({
onClick={onClose}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using optional chaining (onClick={onClose}onClick={onClose ?? undefined}) or a defensive check to ensure that if onClose is not provided, no error is thrown. While the current usage is safe if the parent always provides the prop when mobile is true, this makes the component more robust to future changes.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves the accessibility of icon-only buttons in the ConversationsSidebar component. By correctly adding aria-label attributes and wrapping visual icons with aria-hidden="true", screen readers will now provide a much clearer and more accurate experience for users. This directly addresses the stated goal of preventing confusing announcements and enhancing screen reader compatibility.

aria-label="Close chats panel"
>
&times;
<span aria-hidden="true">&times;</span>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The addition of aria-label on the button and wrapping the visual icon with <span aria-hidden="true"> is an excellent accessibility improvement. To further enhance maintainability and promote consistency across the application, especially if this pattern is used in multiple places, consider abstracting this into a dedicated IconButton component. This component could encapsulate the accessibility best practices, ensuring they are consistently applied wherever an icon-only button is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant