🎨 Palette: Add ARIA labels and hide visual text in icon-only buttons

[Dexploarer]

💡 What
Added <span aria-hidden="true"> wrappers around visual text characters (like × and ×) inside icon-only buttons in ConversationsSidebar.tsx and ChatView.tsx. Also added a missing aria-label to the delete conversation button.

🎯 Why
Visual text characters inside icon-only buttons with aria-label are read aloud by screen readers, causing redundant or confusing announcements (e.g. "Delete conversation, multiplication sign"). Wrapping these characters in aria-hidden="true" ensures screen readers only read the descriptive aria-label.

📸 Before/After
Before:

<button aria-label="Delete conversation" title="Delete conversation">
  ×
</button>

After:

<button aria-label="Delete conversation" title="Delete conversation">
  <span aria-hidden="true">×</span>
</button>

♿ Accessibility

• Prevents redundant/confusing announcements by screen readers for icon-only buttons.
• Ensures the "Delete conversation" button has a proper accessible name via aria-label.

---

PR created automatically by Jules for task 5399322225431466299 started by @Dexploarer

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e5efb4bc-813b-40c8-a526-319e9f17893c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch palette-aria-labels-icon-buttons-5399322225431466299

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the accessibility of icon-only buttons across the application by ensuring screen readers provide clear and concise announcements. It addresses an issue where visual text characters within buttons, despite having an aria-label, were redundantly read aloud, leading to a confusing user experience for assistive technology users. By hiding these visual characters from screen readers and adding a missing aria-label, the application now offers a more streamlined and accurate auditory interface.

Highlights

• Accessibility enhancement for icon-only buttons: Wrapped visual text characters (like '×' and '×') within icon-only buttons with to prevent redundant screen reader announcements when an aria-label is already present.
• Improved screen reader experience: Added a missing aria-label="Delete conversation" to the delete conversation button in ConversationsSidebar.tsx to provide a proper accessible name.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codereviewbot-ai]

The close button in mobile mode calls the onClose callback, but there is no fallback or warning if onClose is not provided. This could result in a non-functional button with no user feedback. Consider making onClose required when mobile is true, or provide a default no-op function to ensure consistent behavior.

Recommended solution:

if (mobile && !onClose) {
  console.warn('onClose callback should be provided when mobile is true');
}

Or enforce via prop types or TypeScript.

[gemini-code-assist]

Code Review

This pull request improves accessibility for icon-only buttons by adding aria-label attributes and hiding decorative text from screen readers. The changes are well-implemented and follow accessibility best practices. I've added one suggestion to make the aria-label for the delete conversation button more specific, which will further improve the experience for users of assistive technologies by providing more context for the action.

[gemini-code-assist]

For better accessibility, the aria-label should be more specific, especially for controls within a list. This helps users of assistive technologies understand which item the action will apply to. A more descriptive label would be Delete conversation '{conv.title}'. It would also be beneficial to update the title attribute on the previous line to be more specific for users who rely on tooltips.

Suggested change

	aria-label="Delete conversation"
	aria-label={`Delete conversation '${conv.title}'`}