feat:modify remove previous asg after goployer timeout #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoungJinJung
requested review from
Chaaany,
GwonsooLee,
asbubam and
jupitersong
as code owners
asisjinwookim
approved these changes
Sep 9, 2025
YoungJinJung
force-pushed
the
feat/modify-remove-prev-asg-after-timeout
branch
from
f408adb to
cdd0392
Compare
Chaaany
reviewed
Sep 26, 2025
Chaaany
approved these changes
Sep 26, 2025
Contributor
Chaaany
left a comment
Chaaany
left a comment
There was a problem hiding this comment.
Conflict 해소 후 Merge 바랍니다 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #nnn
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs
Description
Goployer is Default timeout 3600s(1h). When Deploy EC2 cannot healtch before timeout, then goployer remove previous AutoSacligGroup.
So, Service return 503, and unavailble status.
In this PR, stroe healtcheck flag and check flag for remove previous auto scaling group
User facing changes (remove if N/A)
Follow-up Work (remove if N/A)