refactor(ntlm): discard trailing bytes in MsvAvSingleHost instead of storing #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…storing Per MS-NLMP spec: "Any fields after the MachineID field MUST be ignored on receipt." https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-nlmp/f221c061-cc40-4471-95da-d2ff71c85c5b This changes SingleHost from Vec<u8> back to [u8; 48], explicitly discarding any trailing bytes (e.g., the 32 extra bytes from Windows 11 Build 26200+) rather than storing them unused. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
mamoreau-devolutions
approved these changes
Jan 5, 2026
mamoreau-devolutions
deleted the
refactor/single-host-discard-trailing-bytes
branch
Member
|
Hi @TheBestTvarynka |
Collaborator
|
Sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per MS-NLMP spec: "Any fields after the MachineID field MUST be ignored on receipt." https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-nlmp/f221c061-cc40-4471-95da-d2ff71c85c5b
This changes SingleHost from Vec back to [u8; 48], explicitly discarding any trailing bytes (e.g., the 32 extra bytes from Windows 11 Build 26200+) rather than storing them unused.