fix(ntlm): accept variable-length MsvAvSingleHost AvPair #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexMartigny
force-pushed
the
fix/single-host-variable-length
branch
from
09d783d to
80c6712
Compare
Contributor
Author
|
Must ignore everything after "MachineId" according to spec. |
Windows 11 Build 26200+ sends an 80-byte MsvAvSingleHost structure instead of the traditional 48 bytes. Per MS-NLMP specification, fields after MachineID MUST be ignored on receipt. This change: - Changes SingleHost from fixed [u8; 48] to Vec<u8> - Relaxes validation from == 48 to >= 48 bytes - Preserves full data for round-trip serialization Fixes RDP credential injection failures when clients use Windows 11 Build 26200 or later.
AlexMartigny
force-pushed
the
fix/single-host-variable-length
branch
from
80c6712 to
5ac8c58
Compare
mamoreau-devolutions
approved these changes
Jan 5, 2026
CBenoit
reviewed
Jan 6, 2026
Member
CBenoit
left a comment
CBenoit
left a comment
There was a problem hiding this comment.
@TheBestTvarynka Can you double check this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows 11 Build 26200+ sends an 80-byte MsvAvSingleHost structure instead of the traditional 48 bytes. Per MS-NLMP specification, fields after MachineID MUST be ignored on receipt.
This change:
Fixes RDP credential injection failures when clients use Windows 11 Build 26200 or later.