Fix missing WinGet updates (issue 4545)#4547
Merged
Gabriel Dufresne (GabrielDuf) merged 3 commits intomainfrom Apr 3, 2026
Merged
Fix missing WinGet updates (issue 4545)#4547Gabriel Dufresne (GabrielDuf) merged 3 commits intomainfrom
Gabriel Dufresne (GabrielDuf) merged 3 commits intomainfrom
Conversation
Copilot started reviewing on behalf of
Gabriel Dufresne (GabrielDuf)
April 3, 2026 12:37
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a regression in WinGet update detection where packages reported by winget upgrade were not being surfaced in UniGetUI’s updates list when using bundled in-proc COM activation.
Changes:
- Switched WinGet update enumeration to use a dedicated composite catalog query (
RemotePackagesFromAllCatalogs) intended to matchwinget upgrade’s behavior. - Added a null-guard for
DefaultInstallVersionto avoid exceptions and log skipped packages.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/UniGetUI.PackageEngine.Managers.WinGet/ClientHelpers/NativeWinGetHelper.cs
Outdated
Show resolved
Hide resolved
src/UniGetUI.PackageEngine.Managers.WinGet/ClientHelpers/NativeWinGetHelper.cs
Outdated
Show resolved
Hide resolved
Copilot started reviewing on behalf of
Gabriel Dufresne (GabrielDuf)
April 3, 2026 12:59
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/UniGetUI.PackageEngine.Managers.WinGet/ClientHelpers/NativeWinGetHelper.cs
Show resolved
Hide resolved
src/UniGetUI.PackageEngine.Managers.WinGet/ClientHelpers/NativeWinGetHelper.cs
Outdated
Show resolved
Hide resolved
src/UniGetUI.PackageEngine.Managers.WinGet/ClientHelpers/NativeWinGetHelper.cs
Outdated
Show resolved
Hide resolved
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users reported that some packages shown as upgradable by
winget upgradewere not appearing in the UniGetUI updates list. This regression was introduced in d324a0f, which changed WinGet COM activation to prefer the bundled in-proc DLL over the system COM registration.The bundled
WindowsPackageManager.dlldoes not reliably populateIsUpdateAvailablewhen the composite catalog usesCompositeSearchBehavior.LocalCatalogs, causing most updates to be silently skipped.Fix
Introduced
GetWinGetPackagesForUpdates(), a dedicated catalog query method for update detection that usesCompositeSearchBehavior.RemotePackagesFromAllCatalogs. This mirrors the behavior ofwinget upgradeinternally and correctly resolves update availability against remote catalog data regardless of which COM activation mode is in use.The existing
GetLocalWinGetPackages()withLocalCatalogsis preserved for installed packages listing, where itremains correct and efficient.
Also added an explicit null guard on
DefaultInstallVersioninGetAvailableUpdates_UnSafe()to surface skippedpackages as warnings rather than silent exceptions.