Skip to content

Fix release workflow WinGet payload handling #4446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Marc-André Moreau (mamoreau-devolutions) merged 3 commits into from
Mar 10, 2026
+150 −36
Merged

Fix release workflow WinGet payload handling #4446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c04f758
Fix winget bundle fetch fallback
mamoreau-devolutions Mar 10, 2026
dae7511
Skip signing during release dry runs
mamoreau-devolutions Mar 10, 2026
76a58ab
Cache WinGet CLI payload in release workflow
mamoreau-devolutions Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/build-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,14 +147,29 @@ jobs:
$PackageVersion = '${{ needs.preflight.outputs.package-version }}'
.\scripts\set-version.ps1 -Version $PackageVersion

- name: Restore WinGet CLI cache
id: winget-cache
uses: actions/cache/restore@v4
with:
path: src/UniGetUI.PackageEngine.Managers.WinGet/winget-cli_${{ matrix.platform }}
key: winget-cli-${{ runner.os }}-${{ matrix.platform }}-${{ hashFiles('scripts/fetch-winget-cli.ps1') }}

- name: Fetch WinGet CLI bundle
if: steps.winget-cache.outputs.cache-hit != 'true'
shell: pwsh
env:
GITHUB_TOKEN: ${{ github.token }}
run: |
$Platform = '${{ matrix.platform }}'
.\scripts\fetch-winget-cli.ps1 -Architectures @($Platform) -Force

- name: Save WinGet CLI cache
if: steps.winget-cache.outputs.cache-hit != 'true'
uses: actions/cache/save@v4
with:
path: src/UniGetUI.PackageEngine.Managers.WinGet/winget-cli_${{ matrix.platform }}
key: ${{ steps.winget-cache.outputs.cache-primary-key }}

- name: Restore dependencies
working-directory: src
run: dotnet restore
Expand Down Expand Up @@ -188,6 +203,7 @@ jobs:
Copy-Item "unigetui_bin/UniGetUI.exe" "unigetui_bin/WingetUI.exe" -Force

- name: Code-sign binaries
if: ${{ fromJSON(needs.preflight.outputs.dry-run) == false }}
shell: pwsh
run: |
$ListPath = Join-Path $PWD "signing-files.txt"
Expand Down Expand Up @@ -246,6 +262,7 @@ jobs:
# Installer is created in output during the previous step

- name: Code-sign installer
if: ${{ fromJSON(needs.preflight.outputs.dry-run) == false }}
shell: pwsh
run: |
$Platform = '${{ matrix.platform }}'
Expand Down
169 changes: 133 additions & 36 deletions scripts/fetch-winget-cli.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ param(
[string] $Version = "v1.12.470",
[string[]] $Architectures = @("x64", "arm64"),
[string] $DestinationRoot = (Join-Path $PSScriptRoot ".." "src" "UniGetUI.PackageEngine.Managers.WinGet"),
[string] $UpstreamRepo = "marticliment/UniGetUI",
[string] $UpstreamRepo = "",
[string] $UpstreamRef = "main",
[string] $UpstreamReferencePath = "src/UniGetUI.PackageEngine.Managers.WinGet/winget-cli_x64",
[string] $UpstreamReferencePath = "",
[string] $GitHubToken = "",
[switch] $Force
)
Expand Down Expand Up @@ -52,9 +52,65 @@ else {
Write-Warning "No GitHub token found (GITHUB_TOKEN/GH_TOKEN). Requests may be rate-limited."
}

$X64OnlyReferenceFiles = @(
"AppInstallerBackgroundTasks.dll"
)
$BundledReferenceFiles = @{
x64 = @(
"concrt140_app.dll",
"libsmartscreenn.dll",
"Microsoft.Management.Configuration.dll",
"Microsoft.Web.WebView2.Core.dll",
"msvcp140_1_app.dll",
"msvcp140_2_app.dll",
"msvcp140_app.dll",
"msvcp140_atomic_wait_app.dll",
"resources.pri",
"vcamp140_app.dll",
"vccorlib140_app.dll",
"vcomp140_app.dll",
"vcruntime140_1_app.dll",
"vcruntime140_app.dll",
"WindowsPackageManager.dll",
"WindowsPackageManagerServer.exe",
"winget.exe"
)
arm64 = @(
"concrt140_app.dll",
"libsmartscreenn.dll",
"Microsoft.Management.Configuration.dll",
"Microsoft.Web.WebView2.Core.dll",
"msvcp140_1_app.dll",
"msvcp140_2_app.dll",
"msvcp140_app.dll",
"msvcp140_atomic_wait_app.dll",
"resources.pri",
"vcamp140_app.dll",
"vccorlib140_app.dll",
"vcomp140_app.dll",
"vcruntime140_1_app.dll",
"vcruntime140_app.dll",
"WindowsPackageManager.dll",
"WindowsPackageManagerServer.exe",
"winget.exe"
)
x86 = @(
"concrt140_app.dll",
"libsmartscreenn.dll",
"Microsoft.Management.Configuration.dll",
"Microsoft.Web.WebView2.Core.dll",
"msvcp140_1_app.dll",
"msvcp140_2_app.dll",
"msvcp140_app.dll",
"msvcp140_atomic_wait_app.dll",
"resources.pri",
"vcamp140_app.dll",
"vccorlib140_app.dll",
"vcomp140_app.dll",
"vcruntime140_1_app.dll",
"vcruntime140_app.dll",
"WindowsPackageManager.dll",
"WindowsPackageManagerServer.exe",
"winget.exe"
)
}

function Get-ReleaseInfo {
param([string] $Tag)
Expand Down Expand Up @@ -126,6 +182,62 @@ function Resolve-UpstreamReferencePathForArchitecture {
return $BasePath
}

function Get-BundledReferenceFiles {
param([string] $Architecture)

$archKey = $Architecture.ToLowerInvariant()
if ($BundledReferenceFiles.ContainsKey($archKey)) {
return @($BundledReferenceFiles[$archKey])
}

return @($BundledReferenceFiles["x64"])
}

function Get-ReferenceFiles {
param([string] $Architecture)

$archKey = $Architecture.ToLowerInvariant()
$upstreamConfigured = -not [string]::IsNullOrWhiteSpace($UpstreamRepo) -and -not [string]::IsNullOrWhiteSpace($UpstreamReferencePath)

if ($upstreamConfigured) {
$upstreamReferencePathForArch = Resolve-UpstreamReferencePathForArchitecture -BasePath $UpstreamReferencePath -Architecture $archKey

try {
$upstreamFiles = Get-UpstreamReferenceFiles -Repository $UpstreamRepo -Ref $UpstreamRef -DirectoryPath $upstreamReferencePathForArch

return @{
Files = @($upstreamFiles)
SourceDescription = "$UpstreamRepo@$UpstreamRef/$upstreamReferencePathForArch"
}
}
catch {
if ($upstreamReferencePathForArch -ne $UpstreamReferencePath) {
Write-Warning "Unable to load architecture-specific upstream reference '$upstreamReferencePathForArch'. Falling back to '$UpstreamReferencePath'."

try {
$upstreamFiles = Get-UpstreamReferenceFiles -Repository $UpstreamRepo -Ref $UpstreamRef -DirectoryPath $UpstreamReferencePath

return @{
Files = @($upstreamFiles)
SourceDescription = "$UpstreamRepo@$UpstreamRef/$UpstreamReferencePath"
}
}
catch {
Write-Warning "Unable to load upstream reference '$UpstreamRepo@$UpstreamRef/$UpstreamReferencePath'. Falling back to bundled reference manifest."
}
}
else {
Write-Warning "Unable to load upstream reference '$UpstreamRepo@$UpstreamRef/$UpstreamReferencePath'. Falling back to bundled reference manifest."
}
}
}

return @{
Files = @(Get-BundledReferenceFiles -Architecture $archKey)
SourceDescription = "bundled manifest ($archKey)"
}
}

$release = Get-ReleaseInfo -Tag $Version
Write-Host "Using winget-cli release: $($release.tag_name)"

Expand Down Expand Up @@ -154,30 +266,10 @@ Expand-Archive -Path $depsPath -DestinationPath $depsDir -Force

foreach ($arch in $Architectures) {
$archKey = $arch.ToLowerInvariant()
$upstreamReferencePathForArch = Resolve-UpstreamReferencePathForArchitecture -BasePath $UpstreamReferencePath -Architecture $archKey
$reference = Get-ReferenceFiles -Architecture $archKey
$expectedFiles = @($reference.Files)

try {
$upstreamFiles = Get-UpstreamReferenceFiles -Repository $UpstreamRepo -Ref $UpstreamRef -DirectoryPath $upstreamReferencePathForArch
}
catch {
if ($upstreamReferencePathForArch -ne $UpstreamReferencePath) {
Write-Warning "Unable to load architecture-specific upstream reference '$upstreamReferencePathForArch'. Falling back to '$UpstreamReferencePath'."
$upstreamReferencePathForArch = $UpstreamReferencePath
$upstreamFiles = Get-UpstreamReferenceFiles -Repository $UpstreamRepo -Ref $UpstreamRef -DirectoryPath $upstreamReferencePathForArch
}
else {
throw
}
}

$expectedFiles = if ($archKey -eq 'x64') {
$upstreamFiles
}
else {
@($upstreamFiles | Where-Object { $_ -notin $X64OnlyReferenceFiles })
}

Write-Host "[$archKey] Using upstream reference list from $UpstreamRepo@$UpstreamRef/$upstreamReferencePathForArch ($($upstreamFiles.Count) files)"
Write-Host "[$archKey] Using reference list from $($reference.SourceDescription) ($($expectedFiles.Count) files)"

$msix = Get-ChildItem $bundleDir -Filter "*${archKey}*.msix" -Recurse | Select-Object -First 1
if (-not $msix) {
Expand Down Expand Up @@ -207,15 +299,20 @@ foreach ($arch in $Architectures) {
$source = Get-ChildItem $depsArchDir -Recurse -Filter $fileName -File | Select-Object -First 1
}
if (-not $source) {
$fallbackUrl = "https://raw.githubusercontent.com/${UpstreamRepo}/${UpstreamRef}/${upstreamReferencePathForArch}/${fileName}"
Write-Warning "Release payload missing '$fileName' for $arch. Downloading fallback from upstream reference."
try {
Invoke-WebRequest -Uri $fallbackUrl -OutFile $destinationFile -Headers $Headers
continue
}
catch {
throw "Required upstream file '$fileName' not found for $arch and fallback download failed: $fallbackUrl"
if (-not [string]::IsNullOrWhiteSpace($UpstreamRepo) -and -not [string]::IsNullOrWhiteSpace($UpstreamReferencePath)) {
$upstreamReferencePathForArch = Resolve-UpstreamReferencePathForArchitecture -BasePath $UpstreamReferencePath -Architecture $archKey
$fallbackUrl = "https://raw.githubusercontent.com/${UpstreamRepo}/${UpstreamRef}/${upstreamReferencePathForArch}/${fileName}"
Write-Warning "Release payload missing '$fileName' for $arch. Downloading fallback from upstream reference."
try {
Invoke-WebRequest -Uri $fallbackUrl -OutFile $destinationFile -Headers $Headers
continue
}
catch {
throw "Required upstream file '$fileName' not found for $arch and fallback download failed: $fallbackUrl"
}
}

throw "Required file '$fileName' not found for $arch in the winget release payload."
}

Copy-Item $source.FullName $destinationFile -Force
Expand Down
Loading