-
Notifications
You must be signed in to change notification settings - Fork 0
feat: 조합 생성하기 인터랙션 및 유효성 검증 구현 #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
waldls
wants to merge
18
commits into
develop
Choose a base branch
from
feature/19-combination_create-ui
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+683
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seony777
approved these changes
Jan 16, 2026
Collaborator
Seony777
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
정말 고생 많으셨습니다! 로컬에서 실행해봤고 말씀하신 기능 다 잘 작동하는 것 같습니다.
애니메이션 부분에서 실행 중에 살짝 왼쪽 아래로 이동하는 부분이 있긴한데 큰 문제는 없어 보여 approve합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈번호
close : #19
🔍 구현한 내용
조합명 입력 유효성 검증 로직 구현
사무실 세팅으로 하드코딩되어 있습니다.)입력 UX 및 버튼 상태 관리
조합 생성 결과 인터랙션 및 애니메이션 구현
생성 완료 후 사용자 흐름 연결
/devices)로 이동하도록 라우팅을 연결했습니다.모션 관련 상수 분리 및 구조 정리
COMBO_MOTION상수로 분리했습니다.📸 스크린샷 or 실행 영상
default.mp4
📢 리뷰어에게
i) 로그인 상태에서
[조합 생성하기]클릭 시 조합이 정상적으로 생성되는 플로우ii) 로그아웃 상태에서
[조합 생성하기]클릭 시 로그인 화면으로 자동 이동하는 플로우