fixbug : JpgEncoder::reserveData return true when not need malloc me… #78
Conversation
There was a problem hiding this comment.
Pull Request Overview
Fixes a bug in the JpgEncoder::reserveData method where it incorrectly returned 0 instead of true when no memory reallocation was needed.
- Changed return value from 0 to true when width and height haven't changed
- Ensures consistent boolean return type behavior for the reserveData method
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| JpgEncoder::reserveData(uint32_t width, uint32_t height) { | ||
| if (width == mMaxWidth && height == mMaxHeight) { | ||
| return 0; | ||
| return true; |
There was a problem hiding this comment.
The function returns true when no reallocation is needed, but this should be verified against the function's contract. If reserveData is expected to return true for success and false for failure, then this change is correct. However, if the function should indicate whether new data was actually reserved, returning true when no allocation occurred might be misleading to callers.
|
LGTM but please add a sign-off so DCO can pass. |
Signed-off-by: wangpeng <wangpeng@kj.com>
PennyWang-Tank
force-pushed
the
master
branch
from
6df22fe to
74e906c
Compare
2 participants
When there is no change in width and height, there is no need to reallocate memory and reuse existing memory.