Upgrade Classic Remix Compiler to Remix Vite#843
Closed
Conversation
This reverts commit a3a4c77.
There was a problem hiding this comment.
Copilot reviewed 13 out of 17 changed files in this pull request and generated no comments.
Files not reviewed (4)
- .dockerignore: Language not supported
- .oxlintrc.json: Language not supported
- Dockerfile: Language not supported
- package.json: Language not supported
Comments suppressed due to low confidence (2)
eslint.config.mjs:16
- Consider using a standard approach to obtain the directory name in ES modules, for example by using fileURLToPath(new URL('.', import.meta.url)) instead of relying on import.meta.dirname.
const gitignorePath = path.resolve(import.meta.dirname, '.gitignore');
server.ts:15
- Ensure that the server file is executed as an ES module to support top-level await; if not, consider refactoring the initialization of viteDevServer into an async context.
const viteDevServer = process.env.NODE_ENV === 'production' ? undefined : await import('vite').then((vite) => vite.createServer({ server: { middlewareMode: true } }));
Member
Author
|
CI is failing on some runs. I'm going to try using https://github.com/kiliman/remix-express-vite-plugin instead of esbuild |
Member
Author
|
I can't figure out how to get the server.ts build working together with Vite, and when trying to use the Remix Express Vite plugin (so we don't need to compile the TypeScript for the server in a separate step), the server doesn't start at all. If we really want to do this I see two ways forward:
cc @humphd |
Contributor
|
@uday-rana I'd say let's not rush this (and #895) into the upcoming release. Seems like there are still some decisions to be made |
This was referenced Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Remix Vite: Migrating
How to Fix CJS/ESM Bugs in Remix
remix-run/remix#8978
remix-run/remix#6004 (reply in thread)