Skip to content

Upgrade Classic Remix Compiler to Remix Vite#843

Closed
uday-rana wants to merge 40 commits intomainfrom
remix-vite
Closed

Upgrade Classic Remix Compiler to Remix Vite#843
uday-rana wants to merge 40 commits intomainfrom
remix-vite

Conversation

@uday-rana
Copy link
Member

@uday-rana uday-rana commented Feb 20, 2025

@uday-rana uday-rana marked this pull request as ready for review April 7, 2025 06:24
@uday-rana uday-rana requested a review from Copilot April 7, 2025 07:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 13 out of 17 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • .dockerignore: Language not supported
  • .oxlintrc.json: Language not supported
  • Dockerfile: Language not supported
  • package.json: Language not supported
Comments suppressed due to low confidence (2)

eslint.config.mjs:16

  • Consider using a standard approach to obtain the directory name in ES modules, for example by using fileURLToPath(new URL('.', import.meta.url)) instead of relying on import.meta.dirname.
const gitignorePath = path.resolve(import.meta.dirname, '.gitignore');

server.ts:15

  • Ensure that the server file is executed as an ES module to support top-level await; if not, consider refactoring the initialization of viteDevServer into an async context.
const viteDevServer = process.env.NODE_ENV === 'production' ? undefined : await import('vite').then((vite) => vite.createServer({ server: { middlewareMode: true } }));

@uday-rana
Copy link
Member Author

uday-rana commented Apr 8, 2025

CI is failing on some runs. I'm going to try using https://github.com/kiliman/remix-express-vite-plugin instead of esbuild

@uday-rana
Copy link
Member Author

uday-rana commented Apr 8, 2025

I can't figure out how to get the server.ts build working together with Vite, and when trying to use the Remix Express Vite plugin (so we don't need to compile the TypeScript for the server in a separate step), the server doesn't start at all.

If we really want to do this I see two ways forward:

cc @humphd

@theoforger
Copy link
Contributor

@uday-rana I'd say let's not rush this (and #895) into the upcoming release. Seems like there are still some decisions to be made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants