Conversation
theoforger
force-pushed
the
hydration-bug
branch
3 times, most recently
from
e0268c1 to
7a77c4f
Compare
Contributor
|
Should we do the date change and separate from the e2e stuff, so we can land that bit? |
Contributor
Author
@humphd I was thinking the same. The only thing is we won't be able to verify the effectiveness in CI. If you're okay with that I can take out the e2e test for now 👍 |
Contributor
|
Yeah, let's get your research shipped at least. Tests can come later. |
theoforger
force-pushed
the
hydration-bug
branch
from
7a77c4f to
6a12258
Compare
humphd
previously approved these changes
Nov 28, 2025
Contributor
humphd
left a comment
humphd
left a comment
There was a problem hiding this comment.
Looks good. A couple of suggestions. Thanks for jumping on this, I appreciate the help maintaining things.
theoforger
force-pushed
the
hydration-bug
branch
from
6a12258 to
8b6abe2
Compare
Contributor
Author
|
Of course! I enjoyed working on this project. Glad to see it picked back up :) |
humphd
approved these changes
Nov 28, 2025
Contributor
|
Confirmed fixed on staging: 
|
humphd
added a commit
that referenced
this pull request
Jan 28, 2026
* use client side rendering for local dates (#1014) * Update staging SAML metadata with new SAML signing certificate (#1016) * Update staging SAML metadata with new SAML signing certificate * Updated idp-metadata-dev.xml and idp-metadata-production.xml * Revert idp-metadata-dev.xml back to original --------- Co-authored-by: Mehrdad Ziaei <mehrdad.ziaei@senecapolytechnic.ca> --------- Co-authored-by: TheoForger <theoforger@proton.me> Co-authored-by: mehrdadziaei <53977875+mehrdadziaei@users.noreply.github.com> Co-authored-by: Mehrdad Ziaei <mehrdad.ziaei@senecapolytechnic.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the rendering of certificate valid dates happens on the server side, which could potentially lead to hydration issue and it might be the cause of #845 and #1009. This pull request move the rendering logic to the client side and attempts to re-enable e2e testing.
Update: There seem to be some Prisma-related problem that's also failing the test in addition to the hydration issue. More investigation needed