Skip to content

Don't parse database url before passing to prisma #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
humphd merged 1 commit into from
Nov 26, 2025
Merged

Don't parse database url before passing to prisma #1012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 3 additions & 15 deletions app/db.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,18 +34,9 @@ function getClient() {
throw new Error('DATABASE_URL secret not set');
}

const databaseUrl = new URL(DATABASE_URL);
logger.info(`🔌 setting up prisma client to ${new URL(DATABASE_URL).host}`);

logger.info(`🔌 setting up prisma client to ${databaseUrl.host}`);

const adapter = new PrismaMariaDb({
host: databaseUrl.hostname,
port: parseInt(databaseUrl.port || '3306'),
user: databaseUrl.username,
password: databaseUrl.password,
database: databaseUrl.pathname.slice(1), // Remove leading '/'
connectionLimit: 5,
});
const adapter = new PrismaMariaDb(DATABASE_URL);

// NOTE: during development if you change anything in this function, remember
// that this only runs once per server restart and won't automatically be
Expand All @@ -54,10 +45,7 @@ function getClient() {
const client = new PrismaClient({ adapter });

// connect eagerly
client
.$connect()
.then(() => console.debug('✅ Prisma connected successfully'))
.catch((err) => console.error('❌ Prisma connection failed:', err));
client.$connect();

return client;
}
Expand Down
13 changes: 1 addition & 12 deletions prisma/seed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,11 @@ import { PrismaClient } from '@prisma/client-and-server';
import { PrismaMariaDb } from '@prisma/adapter-mariadb';

const DATABASE_URL = process.env.DATABASE_URL;

if (!DATABASE_URL) {
throw new Error('DATABASE_URL environment variable is not set');
}

// Parse connection details
const url = new URL(DATABASE_URL);
const adapter = new PrismaMariaDb({
host: url.hostname,
port: parseInt(url.port || '3306'),
user: url.username,
password: url.password,
database: url.pathname.slice(1),
connectionLimit: 5,
});

const adapter = new PrismaMariaDb(DATABASE_URL);
const prisma = new PrismaClient({ adapter });

async function seed() {
Expand Down