-
Notifications
You must be signed in to change notification settings - Fork 8
Don't pin the rust compiler used to build wasmtime #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Don't pin the rust compiler used to build wasmtime #333
Conversation
This allows building with nixpkgs versions that do not provide specifically rust_1_89.
📝 WalkthroughWalkthroughUpdated the Nix package derivation in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cole-h
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I review-requested Eelco to see if there was a specific reason.
|
Ah, that's why: So it looks like we do need to specify 1.89... Maybe there's some niceness we can do so that it works for both of us. (I'll look in the morning.) |
|
Ah, it was pinned to a newer version. I'll admit I just unpinned it and verified it started building... 😓 One possible solution is to update the nixpkgs pin from 25.05 to 25.11, but there may be other reasons not to do that. If you do want to update the pin to 25.11, I made a branch with the changes I think are required at https://github.com/bryceberger/detnix/tree/nixpkgs-25.11 (permalink: https://github.com/bryceberger/detnix/commits/56fb7a232690c2bd30542587e6f2423c09782bed). Not sure if they're all the right changes, will leave that to someone with more knowledge. Just kept poking things until |
This allows building with nixpkgs versions that do not provide specifically rust_1_89.
Motivation
I pin nixpkgs in my config, then set
determinate.inputs.nixpkgs.follows = "nixpkgs". The nixpkgs I have pinned does not providerust_1_89.Context
Added in #309, specifically d049bf3. I don't see any specific reasoning in the PR for pinning the compiler version.
Upstream nixpkgs just uses bare
rustPlatform: https://github.com/NixOS/nixpkgs/blob/18451d41a40765408adb9f3f20e76c151fdfa307/pkgs/by-name/wa/wasmtime/package.nixSummary by CodeRabbit