wip: abort when throwing std::logic_error, else continue

[cole-h]

Motivation

Context

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

• 🔍 Trigger a full review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch abort-on-logic-error

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

• ✨ 136.113.208.247/32 (new)
• 34.170.211.100/32
• 35.222.179.152/32

Failure to add the new IP will result in interrupted reviews.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🚀 Deployed on https://698203f6c2924442854bbbce--determinate-nix.netlify.app

[proski]

Any chance the second argument could be declared std::type_info * instead of void *? That would make the tinfo / tinfo_ distinction unnecessary.

[edolstra]

That changes the mangled name in a way that doesn't match the real __cxa_throw, so unfortunately it doesn't work.

[edolstra]

ld has a --wrap feature that could be used to wrap __cxa_throw, hopefully in a way that would also work on static builds. See https://linux.die.net/man/1/ld.

We're already using that for __assert_fail, see nix-meson-build-support/common/assert-fail.

However, I'm not sure if that will redirect references in shared libraries like libstdc++.