-
Notifications
You must be signed in to change notification settings - Fork 2
Revert "Switch to secure packages" #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe PR updates GitHub Actions workflows with formatting consistency and permission adjustments, reorganizes documentation references, and refactors the flake.nix outputs function signature from destructuring pattern Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20–30 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
292bdd2 to
565b40f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/determinate-ci.yml (1)
9-9: Quoted tag pattern and explicit permissions look good; confirm OIDC needQuoting the tag pattern and setting
flake-iter-flakeref: ".#"are both appropriate and keep the workflow unambiguous. Thepermissionsblock (id-token: "write",contents: "read") matches typical requirements for OIDC-based reusable workflows likeDeterminateSystems/ci; just confirm that this job still relies on those tokens post‑revert and trim the block if they’re no longer needed.Also applies to: 18-20, 23-29
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
flake.lockis excluded by!**/*.lock
📒 Files selected for processing (5)
.github/workflows/determinate-ci.yml(2 hunks).github/workflows/nix.yml(0 hunks).github/workflows/rust.yml(0 hunks)README.md(1 hunks)flake.nix(4 hunks)
💤 Files with no reviewable changes (2)
- .github/workflows/rust.yml
- .github/workflows/nix.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: DeterminateCI / build (aarch64-darwin, macos-latest)
- GitHub Check: DeterminateCI / build (aarch64-linux, ubuntu-24.04-arm)
- GitHub Check: DeterminateCI / build (x86_64-linux, ubuntu-latest)
- GitHub Check: rust-fmt-and-clippy
🔇 Additional comments (2)
README.md (1)
55-60: README runner mapping reorder is fineThe added blank line and reordered JSON keys are purely cosmetic; the documented default mapping remains accurate and unambiguous.
flake.nix (1)
6-7: Revert to public nixpkgs andinputs:binding looks correctPointing
nixpkgsathttps://flakehub.com/f/NixOS/nixpkgs/0aligns with the “revert secure packages” goal, and switching tooutputs = inputs:withinputs.self/inputs.nixpkgscleanly preserves the prior overlay wiring and cranesrcbehavior. Please runnix flake checkacross your supported systems to confirm everything still evaluates against the new nixpkgs source.Also applies to: 17-18, 27-33, 91-98
Reverts #37 because non-customers cannot access it.
Summary by CodeRabbit
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.