Skip to content

Conversation

@lucperkins
Copy link
Member

@lucperkins lucperkins commented Sep 25, 2025

Summary by CodeRabbit

  • Chores
    • Updated CI workflow to activate the SSH agent only when the related input is explicitly set to “true,” improving predictability for inventory and build steps and reducing unintended SSH usage. No changes to product features or user-facing behavior.

@coderabbitai
Copy link

coderabbitai bot commented Sep 25, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Updated GitHub Actions workflow conditions to explicitly compare the input enable-ssh-agent to the string 'true' for the inventory and build steps. No other structural or logic changes were made.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
\.github/workflows/workflow.yml
Changed two step conditions from if: ${{ inputs.enable-ssh-agent }} to if: ${{ inputs.enable-ssh-agent == 'true' }} (affecting inventory and build steps).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A toggle flips with tidy cheer,
'true' now spoken, crystal clear.
I thump my paw—no ifs askew,
The build hops only when it's due.
Carrot logs show green on through! 🥕🐇

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-ssh-agent-logic

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e257db1 and 6adf73b.

📒 Files selected for processing (1)
  • .github/workflows/workflow.yml (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lucperkins lucperkins closed this Sep 25, 2025
@lucperkins
Copy link
Member Author

I mistakenly thought that inputs.enable-ssh-agent was being incorrectly registered as true in all cases, but further investigation revealed that to not be the case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants