Skip to content

[feature] SC-166737/improve app proxy security by restricting where token replacements can go #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HappyPaul55 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[feature] SC-166737/improve app proxy security by restricting where token replacements can go #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
188 changes: 100 additions & 88 deletions manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,93 +1,105 @@
{
"name": "@deskpro-apps/trello",
"title": "Trello",
"description": "Integrate Trello with your helpdesk to improve your management of your tasks",
"appStoreUrl": "https://www.deskpro.com/product-embed/apps/trello",
"version": "1.1.29",
"scope": "agent",
"isSingleInstall": false,
"hasDevMode": true,
"serveUrl": "https://apps-cdn.deskpro-service.com/__name__/__version__",
"targets": [
{
"target": "ticket_sidebar",
"entrypoint": "index.html",
"options": {
"actions": {
"linkTicket": {
"type": "ticket_addition",
"title": "Trello Card",
"description": "Link ticket to a Trello card"
}
}
}
}
],
"settings": {
"api_key": {
"title": "API Key",
"type": "string",
"isRequired": true,
"isBackendOnly": false,
"order": 10
},
"callback_url": {
"title": "Callback URL Origin",
"type": "app_embedded",
"options": { "entrypoint": "#/admin/callback" },
"isRequired": false,
"isBackendOnly": true,
"order": 20
},
"add_comment_when_linking": {
"title": "Leave a comment on the card in Trello when it is linked to a ticket in Deskpro",
"description": "",
"type": "boolean",
"default": true,
"isRequired": false,
"isBackendOnly": false,
"order": 30
},
"default_comment_on_ticket_reply": {
"title": "Ticket reply as comment",
"description": "Enable option to add Deskpro replies as card comments when a Trello card is linked to a Deskpro ticket",
"type": "boolean",
"isRequired": false,
"isBackendOnly": false,
"order": 40
},
"default_comment_on_ticket_note": {
"title": "Ticket note as comment",
"description": "Enable option to add Deskpro notes as card comments when a Trello card is linked to a Deskpro ticket",
"type": "boolean",
"isRequired": false,
"isBackendOnly": false,
"order": 50
},
"add_deskpro_label": {
"title": "Add \"Deskpro\" label when creating or linking Card",
"description": "Automatically adding a label to indicate in Trello that the card is currently linked to a Deskpro ticket",
"type": "boolean",
"default": true,
"isRequired": false,
"isBackendOnly": false,
"order": 60
"name": "@deskpro-apps/trello",
"title": "Trello",
"description": "Integrate Trello with your helpdesk to improve your management of your tasks",
"appStoreUrl": "https://www.deskpro.com/product-embed/apps/trello",
"version": "1.1.29",
"scope": "agent",
"isSingleInstall": false,
"hasDevMode": true,
"serveUrl": "https://apps-cdn.deskpro-service.com/__name__/__version__",
"targets": [
{
"target": "ticket_sidebar",
"entrypoint": "index.html",
"options": {
"actions": {
"linkTicket": {
"type": "ticket_addition",
"title": "Trello Card",
"description": "Link ticket to a Trello card"
}
}
}
}
],
"settings": {
"api_key": {
"title": "API Key",
"type": "string",
"isRequired": true,
"isBackendOnly": false,
"order": 10
},
"entityAssociations": {
"linkedTrelloCards": {
"title": "Linked Trello Card",
"entity": "ticket",
"type": "external_id"
}
"callback_url": {
"title": "Callback URL Origin",
"type": "app_embedded",
"options": {
"entrypoint": "#/admin/callback"
},
"isRequired": false,
"isBackendOnly": true,
"order": 20
},
"add_comment_when_linking": {
"title": "Leave a comment on the card in Trello when it is linked to a ticket in Deskpro",
"description": "",
"type": "boolean",
"default": true,
"isRequired": false,
"isBackendOnly": false,
"order": 30
},
"proxy": {
"whitelist": [
{
"url": "https://api.trello.com/.*",
"methods": ["GET", "POST", "PUT", "DELETE"],
"timeout": 10
}
]
"default_comment_on_ticket_reply": {
"title": "Ticket reply as comment",
"description": "Enable option to add Deskpro replies as card comments when a Trello card is linked to a Deskpro ticket",
"type": "boolean",
"isRequired": false,
"isBackendOnly": false,
"order": 40
},
"default_comment_on_ticket_note": {
"title": "Ticket note as comment",
"description": "Enable option to add Deskpro notes as card comments when a Trello card is linked to a Deskpro ticket",
"type": "boolean",
"isRequired": false,
"isBackendOnly": false,
"order": 50
},
"add_deskpro_label": {
"title": "Add \"Deskpro\" label when creating or linking Card",
"description": "Automatically adding a label to indicate in Trello that the card is currently linked to a Deskpro ticket",
"type": "boolean",
"default": true,
"isRequired": false,
"isBackendOnly": false,
"order": 60
}
}
},
"entityAssociations": {
"linkedTrelloCards": {
"title": "Linked Trello Card",
"entity": "ticket",
"type": "external_id"
}
},
"proxy": {
"whitelist": [
{
"url": "https://api.trello.com/.*",
"methods": [
"GET",
"POST",
"PUT",
"DELETE"
],
"timeout": 10,
"settingsInjection": {
"api_key": {
"querystring": ["key"]
}
}
}
]
}
}
Loading