Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR strictly updates application and tooling dependencies in package.json (and the corresponding pnpm-lock.yaml) to newer compatible minor/patch versions, without changing any application code or scripts. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `package.json:61` </location>
<code_context>
- "typescript": "^5.8.3",
- "vite": "^6.3.6"
+ "ts-jest": "^29.4.6",
+ "typescript": "^5.9.3",
+ "vite": "^6.4.1"
}
</code_context>
<issue_to_address>
**suggestion:** Consider alignment between the TypeScript version and the pinned @typescript-eslint tooling.
TypeScript is being upgraded while `@typescript-eslint/eslint-plugin` and `@typescript-eslint/parser` stay pinned at `6.20.0`. New TS 5.9.x syntax or flags might not be understood by that version. Please either confirm 6.20.0 officially supports TS 5.9 or bump the @typescript-eslint packages to a version that does.
Suggested implementation:
```
"@typescript-eslint/eslint-plugin": "^8.0.0",
```
```
"@typescript-eslint/parser": "^8.0.0",
```
```
"ts-jest": "^29.4.6",
"typescript": "^5.9.3",
"vite": "^6.4.1"
```
1. After bumping `@typescript-eslint/*`, run `pnpm install` / `npm install` / `yarn install` as appropriate to update the lockfile.
2. Run the lint task (e.g. `pnpm lint`) to confirm there are no new config deprecations or rule name changes required by the newer `@typescript-eslint` major version.
3. If your repo pins `@typescript-eslint` versions in any shared config package or separate `package.json` (e.g., for tooling or examples), apply the same version bumps there for consistency.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
There was a problem hiding this comment.
Pull request overview
This pull request upgrades multiple dependencies in the project to their latest minor or patch versions. The changes include updates to core runtime dependencies like Deskpro SDK packages, Sentry monitoring, and React Router, as well as development dependencies such as SWC compiler, testing libraries, TypeScript, and Vite.
Key changes:
- Updated core runtime dependencies (Deskpro SDK, Sentry, React Query, React Router, styled-components)
- Updated development tooling dependencies (SWC, testing libraries, TypeScript, Vite)
- All updates appear to be minor or patch version increments without major version changes
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated version specifiers for 19 dependencies (10 runtime, 9 development) |
| pnpm-lock.yaml | Updated lockfile with resolved versions and dependency trees for all upgraded packages |
All dependency upgrades in this PR appear to be minor or patch version updates, which typically maintain backward compatibility. No breaking changes or problematic version updates were identified during the review.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request updates several dependencies in the
package.jsonfile to their latest minor or patch versions. These updates help ensure compatibility, improved features, and bug fixes across both runtime and development environments.Dependency updates:
@deskpro/app-sdk,@deskpro/deskpro-ui,@sentry/react,@sentry/vite-plugin,@tanstack/react-query,react-router-dom, andstyled-componentsto newer versions.Development tooling updates:
@swc/core,@swc/helpers,@testing-library/jest-dom,@types/react,@vitejs/plugin-react,jest-environment-jsdom,ts-jest,typescript, andviteto their latest versions.Summary by Sourcery
Update application and tooling dependencies to newer minor and patch versions to keep the project current and compatible.
Enhancements: