Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR bumps a set of runtime, UI, tooling, and testing dependencies in package.json to newer minor/patch versions, with the corresponding updates captured in pnpm-lock.yaml, without changing application code. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
jest-environment-jsdomversion was bumped to^30.2.0whilejestremains on^29.7.0; it would be safer to align these major versions or confirm that the v30 environment is compatible with Jest 29 to avoid subtle test runner issues. - Since
typescriptandvitewere both upgraded to newer minor versions, it may be worth quickly checking that any custom compiler or bundler configuration (tsconfig, Vite plugins) still matches the new defaults and doesn’t rely on deprecated options.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `jest-environment-jsdom` version was bumped to `^30.2.0` while `jest` remains on `^29.7.0`; it would be safer to align these major versions or confirm that the v30 environment is compatible with Jest 29 to avoid subtle test runner issues.
- Since `typescript` and `vite` were both upgraded to newer minor versions, it may be worth quickly checking that any custom compiler or bundler configuration (tsconfig, Vite plugins) still matches the new defaults and doesn’t rely on deprecated options.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Build for commit d50cba2 deployed to: https://salesforce-pr-90.ci.next.deskprodemo.com URLs: |
There was a problem hiding this comment.
Pull request overview
This pull request performs a comprehensive dependency update across the project, upgrading approximately 15 direct dependencies and their transitive dependencies to their latest minor or patch versions. The updates focus on build tools, UI libraries, error monitoring, testing frameworks, and React-related packages. All changes are backward-compatible minor or patch version bumps with no breaking changes expected.
Key changes:
- Updated UI and SDK libraries (@deskpro/deskpro-ui, @deskpro/app-sdk)
- Upgraded error monitoring tools (Sentry packages)
- Updated development and build tools (TypeScript 5.8.3 → 5.9.3, Vite 6.3.6 → 6.4.1, @swc/core)
- Upgraded React-related dependencies (react-hook-form, react-router-dom, type definitions)
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated 15 direct dependency versions with minor/patch version bumps |
| pnpm-lock.yaml | Comprehensive lockfile update reflecting all transitive dependency changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request updates several dependencies in the
package.jsonfile to their latest minor or patch versions. These updates primarily focus on keeping the project up-to-date with bug fixes, performance improvements, and new features from upstream libraries.Dependency updates:
@deskpro/deskpro-uito8.4.0and@deskpro/app-sdkto5.1.1, ensuring access to the latest UI components and SDK improvements.@sentry/reactto9.47.1and@sentry/vite-pluginto3.6.1) for improved error monitoring and reporting.@swc/core,typescript,ts-jest, andvitefor better performance and compatibility. [1] [2]react-hook-form,react-router-dom, and type definitions, to their latest versions for enhanced stability and new features. [1] [2]styled-components,@types/lodash, andjest-environment-jsdomto maintain compatibility and receive the latest fixes. [1] [2]Summary by Sourcery
Upgrade frontend, tooling, and testing dependencies to current minor/patch versions to keep the project aligned with upstream libraries.
Enhancements:
Build:
Tests: