Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates application and build tooling dependencies to newer minor/patch versions in package.json and synchronizes the pnpm lockfile accordingly, with no code changes outside dependency metadata. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- Given the jump to TypeScript 5.9.3 while still using ts-jest 27.1.5, it’s worth verifying that ts-jest’s supported TypeScript range aligns with this version to avoid subtle type-checking or test compilation issues; if not, consider bumping ts-jest in the same PR.
- The upgrades to @sentry/* and dompurify include multiple minor versions; please confirm whether any required config or initialization changes from their changelogs need to be reflected in your Sentry setup or sanitization usage so runtime behavior remains consistent.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Given the jump to TypeScript 5.9.3 while still using ts-jest 27.1.5, it’s worth verifying that ts-jest’s supported TypeScript range aligns with this version to avoid subtle type-checking or test compilation issues; if not, consider bumping ts-jest in the same PR.
- The upgrades to @sentry/* and dompurify include multiple minor versions; please confirm whether any required config or initialization changes from their changelogs need to be reflected in your Sentry setup or sanitization usage so runtime behavior remains consistent.
## Individual Comments
### Comment 1
<location> `package.json:53` </location>
<code_context>
"eslint-plugin-react-hooks": "^5.2.0",
"jest": "^29.7.0",
- "jest-environment-jsdom": "^30.0.5",
+ "jest-environment-jsdom": "^30.2.0",
"prettier": "2.8.7",
"react-resize-observer": "^1.1.1",
</code_context>
<issue_to_address>
**issue (bug_risk):** Consider aligning `jest-environment-jsdom`’s major version with `jest` to avoid subtle incompatibilities.
You’re on Jest 29.x but `jest-environment-jsdom` 30.x, which may rely on Jest 30 defaults and APIs and cause subtle breakages (e.g., config shape, environment behavior). Either pin `jest-environment-jsdom` to 29.x for now or upgrade Jest to 30 in tandem.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Build for commit 758d740 deployed to: https://quickbooks-pr-55.ci.next.deskprodemo.com URLs: |
There was a problem hiding this comment.
Pull request overview
This PR updates multiple dependencies and devDependencies to their latest minor or patch versions. The updates include core application dependencies (@deskpro/app-sdk, @deskpro/deskpro-ui, @sentry/react, react-router-dom) and development dependencies (@swc/core, jest-environment-jsdom, typescript, vite). The changes maintain backward compatibility as all updates are within semver-compatible ranges (minor/patch versions).
Key Changes
- Updated Deskpro SDK and UI library to latest minor versions
- Upgraded Sentry packages for improved error tracking
- Updated build tooling (TypeScript, Vite, SWC)
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated version specifiers for 13 dependencies and devDependencies |
| pnpm-lock.yaml | Reflects resolved versions and transitive dependency updates from package.json changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request updates several dependencies and devDependencies in the
package.jsonfile to their latest minor or patch versions. These updates help ensure compatibility, access to new features, and important bug fixes.Dependency updates:
@deskpro/app-sdk,@deskpro/deskpro-ui,@sentry/react,@sentry/vite-plugin,dompurify,react-router-dom, andstyled-componentsto newer versions.DevDependency updates:
@swc/core,@swc/helpers,@types/react,jest-environment-jsdom,typescript, andviteto more recent versions. [1] [2]Summary by Sourcery
Update application and tooling dependencies to current minor and patch versions.
Build: