Skip to content

[feature] SC-166737/improve app proxy security by restricting where token replacements can go #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HappyPaul55 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[feature] SC-166737/improve app proxy security by restricting where token replacements can go #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,34 @@
{
"url": "https://oauth.platform.intuit.com/oauth2/v1/.*",
"methods": ["POST"],
"timeout": 20
"timeout": 20,
"settingsInjection": {
"client_id": {
"header": ["Authorization"]
},
"client_secret": {
"header": ["Authorization"]
},
"integration_key": {
"header": ["Authorization"]
},
"secret_key": {
"header": ["Authorization"]
}
}
Comment on lines +88 to +101
Copy link

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All four credentials (client_id, client_secret, integration_key, secret_key) are configured to inject into the same Authorization header. This appears inconsistent with the actual usage patterns in the codebase: refreshAccessToken.ts uses __integration_key+':'+secret_key.base64__ in the Authorization header, while getQuickBooksAccessToken.ts sends client_id and client_secret in the request body. Consider reviewing whether all these credentials should actually be injected into the Authorization header, or if some should be restricted to body parameters instead.

Copilot uses AI. Check for mistakes.
},
{
"url": "https://developer.api.intuit.com/v2/oauth2/tokens/revoke",
"methods": ["POST"],
"timeout": 20
"timeout": 20,
"settingsInjection": {
"client_id": {
"header": ["Authorization"]
},
"client_secret": {
"header": ["Authorization"]
}
}
}
]
}
Expand Down
2 changes: 1 addition & 1 deletion src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export const placeholders = {
OAUTH2_ACCESS_TOKEN_PATH: 'oauth2/access_token',
OAUTH2_REFRESH_TOKEN_PATH: 'oauth2/refresh_token',
IS_USING_SANDBOX: 'is_using_sandbox',
};
} as const;

export const GLOBAL_CLIENT_ID = 'ABvWsXjB1yre80UrAXj7uDaWUOWPiW7CZ04t0BJgM75UJZYxJ8';

Expand Down
Loading