Open
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR bumps a set of runtime and dev dependencies in package.json (and corresponding resolutions in pnpm-lock.yaml) to newer minor/patch versions, with no code changes, to keep the project aligned with the current Deskpro, Sentry, React Query, router, SWC, Jest, TypeScript, Vite, and type definitions ecosystem. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The
jest-environment-jsdommajor version (30.x) is ahead ofjest(29.x); consider aligning their major versions to avoid subtle runtime or config incompatibilities. - With
typescriptbumped to 5.9.x,ts-jestis still on 27.x; it may be worth upgradingts-jest(and verifying its compatibility matrix) to ensure smooth TypeScript/Jest integration.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `jest-environment-jsdom` major version (30.x) is ahead of `jest` (29.x); consider aligning their major versions to avoid subtle runtime or config incompatibilities.
- With `typescript` bumped to 5.9.x, `ts-jest` is still on 27.x; it may be worth upgrading `ts-jest` (and verifying its compatibility matrix) to ensure smooth TypeScript/Jest integration.
## Individual Comments
### Comment 1
<location> `package.json:58` </location>
<code_context>
"intersection-observer": "^0.12.2",
"jest": "^29.7.0",
- "jest-environment-jsdom": "^30.0.5",
+ "jest-environment-jsdom": "^30.2.0",
"prettier": "2.8.7",
"react-resize-observer": "^1.1.1",
</code_context>
<issue_to_address>
**issue (testing):** Check Jest 29 vs jest-environment-jsdom 30 compatibility to avoid subtle test failures.
`jest` is still ^29.7.0 while `jest-environment-jsdom` is now ^30.2.0. These packages usually align on major versions, and mixing 29.x with 30.x can cause environment mismatches or test breakages. Consider either keeping `jest-environment-jsdom` on 29.x or upgrading Jest to 30.x in sync with whatever you’ve validated.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
This pull request updates various dependencies and development dependencies to their latest minor or patch versions. The changes focus on incremental updates that should maintain backward compatibility while incorporating bug fixes, security patches, and performance improvements.
Key Changes:
- Updated core dependencies including
@deskpro/app-sdk(6.0.6 → 6.0.8),@deskpro/deskpro-ui(8.3.1 → 8.4.0),@sentry/react(9.38.0 → 9.47.1), and@tanstack/react-query(4.40.1 → 4.42.0) - Updated build tools including
@swc/core(1.12.14 → 1.15.8),typescript(5.8.3 → 5.9.3), andvite(6.3.6 → 6.4.1) - Updated type definitions for
@types/lodash,@types/react, and others
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated version specifiers for 14 dependencies and devDependencies to latest minor/patch versions |
| pnpm-lock.yaml | Comprehensive lock file update reflecting all transitive dependency changes from the package.json updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Build for commit 82b1704 deployed to: https://people-hr-pr-61.ci.next.deskprodemo.com URLs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates several dependencies and development dependencies in the
package.jsonfile to their latest minor or patch versions. These updates help ensure compatibility, improve stability, and may include important bug fixes and performance improvements.Dependency updates:
@deskpro/app-sdk,@deskpro/deskpro-ui,@sentry/react,@sentry/vite-plugin,@tanstack/react-query, andreact-router-domto more recent versions.@types/lodashand@types/reactto the latest versions.Development tool updates:
@swc/core,@swc/helpers,jest-environment-jsdom,styled-components,typescript, andviteto their latest minor or patch releases.Summary by Sourcery
Update application and tooling dependencies to newer minor and patch versions for stability and maintenance.
Build: