Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR bumps several runtime and dev dependency versions in package.json (and syncs pnpm-lock.yaml) to newer minor/patch releases, with no code changes, so review should focus on compatibility, build/test health, and potential transitive impacts. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `package.json:51` </location>
<code_context>
"eslint-plugin-react-hooks": "4.3.0",
"jest": "^29.7.0",
- "jest-environment-jsdom": "^30.0.5",
+ "jest-environment-jsdom": "^30.2.0",
"rollup-plugin-copy": "3.4.0",
"slugify": "^1.6.6",
</code_context>
<issue_to_address>
**issue (bug_risk):** Align jest-environment-jsdom major version with Jest core to avoid runtime/test failures.
jest-environment-jsdom is now on the 30.x line while Jest core remains on 29.x. These majors are intended to track each other, and mixing them can cause test runtime issues. Please either keep jest-environment-jsdom on 29.x or upgrade Jest (and related tooling like ts-jest) to 30.x to keep versions aligned.
</issue_to_address>
### Comment 2
<location> `package.json:56` </location>
<code_context>
- "styled-components": "^6.1.19",
+ "styled-components": "^6.2.0",
"ts-jest": "^27.1.5",
- "typescript": "^5.8.3",
- "vite": "^6.3.6"
+ "typescript": "^5.9.3",
+ "vite": "^6.4.1"
}
</code_context>
<issue_to_address>
**issue (bug_risk):** Check ts-jest compatibility with the newer TypeScript and Jest versions.
TypeScript is being bumped to 5.9.x while ts-jest remains at 27.1.5 (originally aligned with Jest 27 and older TS versions) and Jest core is on 29.x. This combination may not be officially supported and could break compilation or test transforms. Please verify compatibility and either upgrade ts-jest to a version that supports Jest 29 + TS 5.9 or align the Jest/TS versions with a configuration that ts-jest 27 officially supports.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Build for commit 39e04ec deployed to: https://nutshell-pr-56.ci.next.deskprodemo.com URLs: |
There was a problem hiding this comment.
Pull request overview
This PR updates multiple dependencies to their latest minor or patch versions, focusing on improving stability, performance, and security through incremental updates. All changes follow semantic versioning with no breaking major version updates.
Key changes:
- Updates core runtime dependencies including @deskpro/app-sdk (6.0.6 → 6.0.8), @deskpro/deskpro-ui (8.3.1 → 8.4.0), and Sentry packages
- Updates build tooling including TypeScript (5.8.3 → 5.9.3), Vite (6.3.6 → 6.4.1), and @swc/core (1.12.14 → 1.15.8)
- Updates testing infrastructure including jest-environment-jsdom (30.0.5 → 30.2.0)
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates 14 dependency versions (7 runtime, 7 dev) with minor/patch version increments |
| pnpm-lock.yaml | Comprehensive lockfile updates reflecting package.json changes and their transitive dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request updates several dependencies in the
package.jsonfile to their latest minor or patch versions. These upgrades include both runtime and development dependencies, which may bring in bug fixes, performance improvements, and new features.Dependency updates:
@deskpro/app-sdk,@deskpro/deskpro-ui,@sentry/react,@sentry/vite-plugin,@swc/core,@tanstack/react-query, andreact-router-domto newer versions.@types/react,jest-environment-jsdom,styled-components,typescript, andviteto newer versions. [1] [2]Summary by Sourcery
Update application and tooling dependencies to newer minor and patch versions.
Enhancements:
Build: