Skip to content

Comments

SC-197733 chore: arbitrary temporary file from tmp symbolic link dir parameter#78

Merged
tidbit1 merged 1 commit intomainfrom
chore/SC-197733/arbitrary-temporary-file-tmp-symbolic-link-dir-parameter
Aug 12, 2025
Merged

SC-197733 chore: arbitrary temporary file from tmp symbolic link dir parameter#78
tidbit1 merged 1 commit intomainfrom
chore/SC-197733/arbitrary-temporary-file-tmp-symbolic-link-dir-parameter

Conversation

@tidbit1
Copy link
Contributor

@tidbit1 tidbit1 commented Aug 12, 2025

Summary by Sourcery

Upgrade the tmp dependency to version 0.2.5 and enforce the new range via a pnpm override, removing the outdated os-tmpdir package from the lockfile

Enhancements:

  • Add a pnpm override for tmp at version ^0.2.4 and update package.json accordingly
  • Bump tmp from 0.0.33 to 0.2.5 in the lockfile and dependency snapshots

Chores:

  • Remove os-tmpdir entries from the pnpm lockfile

@sourcery-ai
Copy link

sourcery-ai bot commented Aug 12, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR introduces a pnpm override for the tmp package to enforce v0.2.x, updates the lockfile to bump tmp to 0.2.5 (removing os-tmpdir), and refreshes related snapshots to reflect the change.

Entity relationship diagram for updated tmp and os-tmpdir dependencies

erDiagram
  TMP {
    string version
    string engines
  }
  OS_TMPDIR {
    string version
    string engines
  }
  TMP ||--o| OS_TMPDIR : depended_on

  %% Changes:
  %% - tmp updated from 0.0.33 to 0.2.5, now requires node >=14.14
  %% - os-tmpdir removed as a dependency of tmp
Loading

File-Level Changes

Change Details Files
Add pnpm override for tmp package
  • Insert overrides block at top of pnpm-lock.yaml for tmp
  • Add pnpm.overrides section in package.json to pin tmp to ^0.2.4
pnpm-lock.yaml
package.json
Update lockfile dependencies and snapshots
  • Remove os-tmpdir resolution and snapshot entries
  • Bump tmp package from 0.0.33 to 0.2.5 with updated integrity and engine requirement
  • Update snapshot references for tmp from 0.0.33 to 0.2.5
pnpm-lock.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tidbit1 - I've reviewed your changes - here's some feedback:

  • Since tmp@0.2.5 now requires Node >=14.14, please update your package.json engines field or CI configuration to enforce that minimum version.
  • You’re maintaining the tmp override in both package.json and pnpm-lock.yaml; consolidating to a single override location will simplify future updates.
  • Review any existing os-tmpdir/tmp usage to ensure the API hasn’t changed in v0.2.x and adjust calls if necessary.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since tmp@0.2.5 now requires Node >=14.14, please update your package.json engines field or CI configuration to enforce that minimum version.
- You’re maintaining the tmp override in both package.json and pnpm-lock.yaml; consolidating to a single override location will simplify future updates.
- Review any existing os-tmpdir/tmp usage to ensure the API hasn’t changed in v0.2.x and adjust calls if necessary.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@tidbit1 tidbit1 requested a review from Copilot August 12, 2025 08:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the tmp dependency from version 0.0.33 to 0.2.5 and adds a pnpm override to enforce the minimum version requirement. The change removes the deprecated os-tmpdir package that was previously used by older versions of tmp.

  • Adds pnpm override configuration to enforce tmp version ^0.2.4
  • Updates the tmp dependency to version 0.2.5 in lockfile
  • Removes outdated os-tmpdir package entries from the lockfile
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@github-actions
Copy link

@tidbit1 tidbit1 merged commit 7448cdc into main Aug 12, 2025
5 checks passed
@tidbit1 tidbit1 deleted the chore/SC-197733/arbitrary-temporary-file-tmp-symbolic-link-dir-parameter branch August 12, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant