[feature] SC-166737/improve app proxy security by restricting where token replacements can go#75
Open
HappyPaul55 wants to merge 2 commits intomainfrom
Conversation
…oken replacements can go
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds automatic API key injection into the Authorization header for all REST endpoints via a new settingsInjection configuration in the manifest, and strengthens type safety by marking the placeholders object as immutable. Class diagram for updated placeholders constantclassDiagram
class placeholders {
+URL: string
+API_KEY: string
<<immutable>>
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
…oken replacements can go
|
Build for commit eb53569 deployed to: https://jira-data-center-pr-75.ci.next.deskprodemo.com URLs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to API authentication and strengthens type safety in the codebase. The most significant changes are grouped below:
API Authentication Enhancements:
settingsInjectionconfiguration to the API manifest, enabling automatic injection of theapi_keyinto theAuthorizationheader for all REST API requests.Type Safety Improvements:
placeholdersobject insrc/constants.tsto useas const, ensuring its properties are treated as immutable and providing better type inference.Summary by Sourcery
Enhance app proxy security by automatically injecting API keys into request headers and bolster type safety in the codebase
New Features:
Enhancements: