Fix: Add timeout to SerpAPI HTTP requests#310
Open
OpenSourceSoul wants to merge 1 commit intoDesearch-ai:mainfrom
Open
Fix: Add timeout to SerpAPI HTTP requests#310OpenSourceSoul wants to merge 1 commit intoDesearch-ai:mainfrom
OpenSourceSoul wants to merge 1 commit intoDesearch-ai:mainfrom
Conversation
The SerpAPI wrapper was making HTTP requests without any timeout, which could cause the validator/miner to hang indefinitely if the SerpAPI service is slow or unresponsive. This adds a 30-second timeout to both ClientSession creation and individual GET requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The SerpAPI wrapper makes HTTP requests without any timeout configured. If SerpAPI is slow or unresponsive, the request hangs indefinitely, blocking the validator or miner.
Solution
Added a 30-second timeout to both the ClientSession and individual GET requests. This prevents indefinite hanging while still allowing reasonable time for API responses.
Why This Matters