Skip to content

Conversation

@tophyr
Copy link
Contributor

@tophyr tophyr commented Jun 24, 2024

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

Use SDL as a git submodule, and incorporate the project directly into our build instead of relying on a prebuilt library provided by a package manager or system configuration. This will enable us to build SDL precisely to our needs, for our build target.

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

@tophyr
Copy link
Contributor Author

tophyr commented Jun 24, 2024

Will need reconciliation with #457

@Lgt2x
Copy link
Member

Lgt2x commented Jun 24, 2024

why not using VCPKG? And we probably don't want SDL unstable master branch

@Lgt2x
Copy link
Member

Lgt2x commented Jun 24, 2024

As discussed on Discord, I'd prefer a unified VCPKG-based solution for our external packages. We don't have a tangible reason to require a personalized (and master branch) SDL2 build right now. VCPKG can apparently be used for Android, and compile libraries in debug mode if we need to.

@Lgt2x Lgt2x closed this Jun 24, 2024
@Lgt2x Lgt2x mentioned this pull request Jun 24, 2024
13 tasks
@tophyr tophyr deleted the intree-sdl branch June 25, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants