Skip to content

Core: prevent crash when applying large flag sets#1059

Merged
DerTyp7214 merged 1 commit intoDerTyp7214:masterfrom
selfmusing:master
Jan 9, 2026
Merged

Core: prevent crash when applying large flag sets#1059
DerTyp7214 merged 1 commit intoDerTyp7214:masterfrom
selfmusing:master

Conversation

@selfmusing
Copy link
Copy Markdown
Contributor

Large flag/XML payloads caused "Argument list too long" when passed to su -c. Write commands via stdin instead of argv to prevent the crash.

Large flag/XML payloads caused "Argument list too long" when passed to `su -c`.
Write commands via stdin instead of argv to prevent the crash.
@selfmusing
Copy link
Copy Markdown
Contributor Author

@DerTyp7214 Is this okay for merge now ?

@DerTyp7214
Copy link
Copy Markdown
Owner

Checking if it builds, when it does yes.

@DerTyp7214 DerTyp7214 merged commit f29b2f3 into DerTyp7214:master Jan 9, 2026
2 checks passed
@DerTyp7214
Copy link
Copy Markdown
Owner

Please check if the APK works, when it does I will merge it to staging

@selfmusing
Copy link
Copy Markdown
Contributor Author

Please check if the APK works, when it does I will merge it to staging

Yeah, it's working fine.

DerTyp7214 added a commit that referenced this pull request Jan 9, 2026
* Core: prevent crash when applying large flag sets (#1059)

Large flag/XML payloads caused "Argument list too long" when passed to `su -c`.
Write commands via stdin instead of argv to prevent the crash.

* Version bump (#1061)

* Update buildCi.yml (#1062)

Fix multi line commits

---------

Co-authored-by: Selfmuser <109387456+selfmusing@users.noreply.github.com>
Co-authored-by: DerBot7214 <37804065+DerTyp7214@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants