[fix][broker] Avoid false WARN log when replicator is already terminated#21
Open
Denovo1998 wants to merge 1 commit intomasterfrom
Open
[fix][broker] Avoid false WARN log when replicator is already terminated#21Denovo1998 wants to merge 1 commit intomasterfrom
Denovo1998 wants to merge 1 commit intomasterfrom
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
AbstractReplicator.closeProducerAsynccan race with termination. In the post-close callback, the state check mixed two different state snapshots, so a normal transition toTerminatedcould be misclassified and logged as an unexpected WARN. This creates noisy logs and makes concurrent shutdown behavior harder to reason about.Modifications
AbstractReplicatorto consistently usesetDisconnectedReswhen evaluatingTerminating/Terminated.testCloseProducerAsyncNoWarnWhenAlreadyTerminatedto cover the race where another thread sets the replicator state toTerminatedwhileproducer.closeAsync()is still in progress.Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: apache#25259