Skip to content

(feature) Allow users to delete characters#215

Open
davidcraig wants to merge 2 commits intoDennisRas:mainfrom
davidcraig:davidcraig/delete-characters
Open

(feature) Allow users to delete characters#215
davidcraig wants to merge 2 commits intoDennisRas:mainfrom
davidcraig:davidcraig/delete-characters

Conversation

@davidcraig
Copy link
Copy Markdown

Add an option under the settings menu to delete characters
image
Clicking the character in the list shows a popup asking to confirm

  • escape or close closes without deleting
  • delete button will delete that character
image

@davidcraig
Copy link
Copy Markdown
Author

davidcraig commented Nov 4, 2025

Relates to #66

@davidcraig
Copy link
Copy Markdown
Author

AI was used to help generate the code with a lot of debugging and adjustments along the way, appears to work ok for me, quite a useful feature personally due to having lots of alts, and deleting alts regularly (eg temp alts for remix etc).

@davidcraig davidcraig force-pushed the davidcraig/delete-characters branch from 3dc594b to 082fe7c Compare November 4, 2025 17:00
@davidcraig
Copy link
Copy Markdown
Author

Squashed commits for cleaner history

@davidcraig davidcraig changed the title Allow users to delete characters (feature) Allow users to delete characters Nov 4, 2025
@davidcraig
Copy link
Copy Markdown
Author

Potential issue, what if character list is large, could be 50-60 or so, might need to think about adjustments to the list, thoughts?

@davidcraig
Copy link
Copy Markdown
Author

Updated to group by index if more than 10 characters, to prevent large list overflowing screen.

@DennisRas
Copy link
Copy Markdown
Owner

DennisRas commented Mar 12, 2026

Hi @davidcraig
I appreciate you.
Sorry for the very late reply. I haven't done much addon work the last 6 months until now.

I do like your PR although it's gonna need some updating because of the big changes to the addon in Midnight.
Also I was thinking the delete option could be on the character dropdown instead with a nested menu item.

@davidcraig
Copy link
Copy Markdown
Author

Whatever you feel is best, I just made the pr because after remix I needed to remove a ton of temp. characters :)

@DennisRas
Copy link
Copy Markdown
Owner

@davidcraig Totally!
I've resurrected the conversation in #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants