Skip to content

Conversation

@spashii
Copy link
Member

@spashii spashii commented Nov 27, 2025

Summary by CodeRabbit

  • Chores
    • Updated base image to the latest stable version.
    • Standardized Python execution approach across production runtime scripts.
    • Enhanced production deployment configuration with additional file handling and updated startup procedures.

✏️ Tip: You can customize this high-level summary in your review settings.

@spashii spashii merged commit 6ba77b5 into main Nov 27, 2025
6 of 8 checks passed
@spashii spashii deleted the fix-scripts-27-nov-25 branch November 27, 2025 12:43
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 27, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Base image bump from tractr/directus-sync:11.13.0 to 11.13.4. Dockerfile copies reorganized and CMD extended for pm2-runtime. Python runtime commands across production scripts wrapped with uv run executor. Gunicorn worker class updated to use AsyncioUvicornWorker variant.

Changes

Cohort / File(s) Summary
Docker Configuration
echo/directus/Dockerfile
Base image updated (11.13.0 → 11.13.4); copy directives reorganized and deduplicated; CMD extended to include pm2-runtime ecosystem bootstrapping
Production Runtime Scripts
echo/server/prod-scheduler.sh, echo/server/prod-worker.sh, echo/server/prod-worker-cpu.sh, echo/server/prod.sh
All Python command invocations wrapped with uv run executor; Gunicorn worker class changed from dembrane.asyncio_uvicorn_worker.AsyncioUvicornWorker to dembrane.gunicorn_worker.AsyncioUvicornWorker; all CLI flags and configuration preserved

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Attention: echo/server/prod.sh worker class naming convention change—verify the new worker class path dembrane.gunicorn_worker.AsyncioUvicornWorker is correctly implemented and backward compatible
  • Attention: Cross-verify uv run availability and behavior parity with direct command invocation across all wrapper scenarios

Suggested labels

improvement

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-scripts-27-nov-25

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 6ff802c and db6204c.

📒 Files selected for processing (5)
  • echo/directus/Dockerfile (1 hunks)
  • echo/server/prod-scheduler.sh (1 hunks)
  • echo/server/prod-worker-cpu.sh (1 hunks)
  • echo/server/prod-worker.sh (1 hunks)
  • echo/server/prod.sh (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

Hi !

Thank you for contributing to Dembrane ECHO! Before we consider your Pull Request, we ask that you sign our Contributor License Agreement (CLA). This is only required for your first Pull Request.

Please review the CLA, and sign it by adding your GitHub username to the contributors.yml file. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants