fixes missing dependencies for the nix builds#741
Closed
kristofvandam wants to merge 1 commit intoDefGuard:mainfrom
Closed
fixes missing dependencies for the nix builds#741kristofvandam wants to merge 1 commit intoDefGuard:mainfrom
kristofvandam wants to merge 1 commit intoDefGuard:mainfrom
Conversation
* Adds `iproute2` to the wrapped `defguard-service` * Adds `update-desktop-database` to the wrapped `defguard-client` * Tauri Builds on the GTK3/WebKitGTK4.1, there was a mismatch with GTK4/WebKitGTK4.1, (GTK4 should use WebKitGTK6.0, but that isn't supported [yet](tauri-apps/tauri#14684) for tauri. * No `Makefile` so we can overwrite/rename `postInstall` with `installPhase`. * Formatting With these changes in place, it fixes issue [DefGuard#728](DefGuard#728).
Contributor
|
Than you so much for your contribution, I've been searching for a way to handle those missing runtime dependencies. I also had some other fixes prepared in a separate PR, so I've incorporated your solution there: #747 Again, thank you. I'm glad to finally be able to get the NixOS module to work :) |
github-project-automation
bot
moved this from Review
to Ready to release
in Backlog & Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iproute2to the wrappeddefguard-serviceupdate-desktop-databaseto the wrappeddefguard-clientMakefileso we can overwrite/renamepostInstallwithinstallPhase.With these changes in place, it fixes issue #728.