fix: add missing types for zh-HANS and zh-HANT (fix #58)#62
Merged
leoncheng57 merged 2 commits intoDeepLcom:mainfrom Feb 27, 2025
Merged
fix: add missing types for zh-HANS and zh-HANT (fix #58)#62leoncheng57 merged 2 commits intoDeepLcom:mainfrom
leoncheng57 merged 2 commits intoDeepLcom:mainfrom
Conversation
|
@Yohannfra Thanks for adding this. @JanEbbing Can we have this in the next release? Would be great with TS support. |
leoncheng57
reviewed
Feb 25, 2025
leoncheng57
approved these changes
Feb 26, 2025
leoncheng57
reviewed
Mar 4, 2025
Comment on lines
+170
to
+173
| } else if (targetLang === 'zh') { | ||
| throw new DeepLError( | ||
| "targetLang='zh' is deprecated, please use 'zh-HANS' or 'zh-HANT' instead.", | ||
| ); |
Member
There was a problem hiding this comment.
Actually we noticed that this is a breaking change (which would not be allowed the next minor version). We will be undoing this part of the MR before the next release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.