Cancel and return failure when user aborted connection#13
Open
Ruakij wants to merge 2 commits intoDeepDiver1975:masterfrom
Open
Cancel and return failure when user aborted connection#13Ruakij wants to merge 2 commits intoDeepDiver1975:masterfrom
Ruakij wants to merge 2 commits intoDeepDiver1975:masterfrom
Conversation
DeepDiver1975
approved these changes
Mar 13, 2024
kesselb
reviewed
Mar 13, 2024
| // Before potentially reading the next chunk, check if user aborted the connection. | ||
| // Ignored (not aborted), when ignore_user_abort is set. | ||
| if (connection_aborted() === 1 && ignore_user_abort() === 0) { | ||
| return array(0, 0, 0); |
Contributor
There was a problem hiding this comment.
What about throwing an exception here? The first element is expected to be an Count64 instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the user has aborted the connection, we should detect it and stop reading & packing the current file we are working on.
I wasnt sure what the best way is to bubble the failure to
addFileFromStream, so i just set everything to 0 and checked that.Feel free to change that.
Because we have already written some data to the outputStream, i consider it dirty. Maybe we should add that to the function documentation?