-
Notifications
You must be signed in to change notification settings - Fork 15
Feat: Delta Sparse Attention #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this allows for tracking high scoring blocks when calculating query sparse attention - we may then use this information in a later block sparse attention kernel.
delta_w was in mask stride, but the current code expects queries to be priuned for delta before going to QSA kernel.
added NotImplementedError for setting bsa_block_size_q kwargs > 1. this should be implemented later if it is possible.
…tion into feat/delta-bsa-hip
implementation for both minheap and plain qsa with block indices seems broken here.
triton autotune causes it to fail. Investigating autotuning bug further
more cleanup on code and tests is needed once the final form of the function is decided
winner update tree works here and is shown to outperform linear online top-k for k>128. Code still needs verification, fixing and cleanup
the operation now computes the global min at the end of the operation so that we can do a smaller compare on the next loop to check for top-k min and avoid unnecessary computation
Fix Autotune Bug
Quick update of Q pooling
bsa_meanpool is for an ablation on mask IoU
added sm_scale, mask, and vars for saving
This was referenced Oct 1, 2025
Contributor
|
Fault Tolerance implemented by for loop 😆 |
kbumsik
approved these changes
Oct 3, 2025
Contributor
kbumsik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GOD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intro
Add Delta Sparse Attention.
Example Fault Tolerance Command